Skip to content

Add configurable store timeout#765

Merged
sgotti merged 1 commit into
sorintlab:masterfrom
snailxr:addconfig
Mar 10, 2020
Merged

Add configurable store timeout#765
sgotti merged 1 commit into
sorintlab:masterfrom
snailxr:addconfig

Conversation

@snailxr

@snailxr snailxr commented Feb 29, 2020

Copy link
Copy Markdown

No description provided.

@snailxr

snailxr commented Mar 1, 2020

Copy link
Copy Markdown
Author

@sgotti Can you review the pull request?

sgotti
sgotti requested changes Mar 4, 2020
View reviewed changes

@sgotti sgotti left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snailxr Thanks for the PR. It LGTM. Please rebase and squash in a single commit adding a better commit message, something like:

*: Add configurable store timeout

Add a command line option to set the store timeout.

@snailxr snailxr changed the title Add StoreTimeout config Add configurable store timeout Mar 4, 2020
@sgotti

sgotti commented Mar 4, 2020

Copy link
Copy Markdown
Member

@snailxr integration tests are failing since the new Store.Config Timeout field introduced in this patch is not set (and will default to 0) when creating the tests stores in https://github.com/sorintlab/stolon/blob/master/tests/integration/utils.go

@snailxr

snailxr commented Mar 4, 2020

Copy link
Copy Markdown
Author

@sgotti Is there a easy way to run the integration tests locally? 😃

@sgotti

sgotti commented Mar 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@snailxr

  • Use a local agola and execute a direct run (also change the .agola/config.jsonnet to remove unneeded tasks)

  • test a specific store with INTEGRATION=1 STOLON_TEST_STORE_BACKEND=etcdv3 PARALLEL=5 bash -x ./test. It requires an etcd v3.x binary in your PATH. It'll use your local installed version of postgres.

sgotti
sgotti requested changes Mar 5, 2020
View reviewed changes

@sgotti sgotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snailxr Integration tests are now successful.

Since a new command line option as been added, also the doc should be regenerated.

You should execute ./scripts/gen_commands_doc.sh and commit changes to the doc/commands files.

*: Add configurable store timeout
ae20309 
Add a command line option to set the store timeout.
@snailxr

snailxr commented Mar 8, 2020

Copy link
Copy Markdown
Author

@sgotti The command documents regenerated

@sgotti

sgotti commented Mar 10, 2020

Copy link
Copy Markdown
Member

@snailxr Thanks! Merging.

@sgotti sgotti merged commit f512d7e into sorintlab:master Mar 10, 2020
@sgotti sgotti mentioned this pull request Mar 10, 2020
Open
@sgotti sgotti added this to the v0.17.0 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgotti sgotti sgotti requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.17.0

Development

Successfully merging this pull request may close these issues.

2 participants

@snailxr @sgotti