Add GCP (GKE) authentication plugin#625
Merged
Merged
Conversation
Need to enable specific auth plugins for stolonctl to work outside cluster. This commit adds just GCP, but we should consider adding all. See [example](https://github.com/kubernetes/client-go/blob/master/examples/out-of-cluster-client-configuration/main.go) Signed-off-by: Don Bowman <[email protected]>
Contributor
Author
|
i don't believe that failure in the consul test is due to my change |
Member
|
@donbowman Thanks for your PR! Yeah, I think we could just add all the clients. |
Contributor
Author
|
my go knowledge isn't strong enough to overcome the dependency hell that is its various module systems in order to import the azure. I would recommend merging this PR so that GCP works, or maybe you know how to update the client-go in such a way it works w/ azurerest. |
Member
|
@donbowman I'll merge this and then prepare a follow up PR to add all the auth plugins. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to enable specific auth plugins for stolonctl to work outside cluster.
Resolves #623 #623
This commit adds just GCP, but we should consider adding all.
See
example
Signed-off-by: Don Bowman [email protected]