Skip to content

Retry when org.freedesktop.Secret.Item.GetSecret fails#9

Merged
eagletmt merged 1 commit intosorah:masterfrom
eagletmt:retry-load-secret
Jun 12, 2016
Merged

Retry when org.freedesktop.Secret.Item.GetSecret fails#9
eagletmt merged 1 commit intosorah:masterfrom
eagletmt:retry-load-secret

Conversation

@eagletmt
Copy link
Collaborator

It occasionally fails with a message "** Message: received an invalid or
unencryptable secret".
In my environment, for i in $(seq 1000); do envchain aws true; done
will print the message about 3-8 times.

My solution is to retry 3 times if such an error is detected.

@sorah
Copy link
Owner

sorah commented Jun 10, 2016

Repro, but fewer times than your environment.

this workaround is acceptable, but I want this to have noted

@eagletmt eagletmt force-pushed the retry-load-secret branch from 6e191c6 to 13aea0d Compare June 12, 2016 05:06
It occasionally fails with a message "** Message: received an invalid or
unencryptable secret".
In my environment, `for i in $(seq 1000); do envchain aws true; done`
will print the message about 3-8 times.

My solution is to retry 3 times if such an error is detected.
@eagletmt eagletmt force-pushed the retry-load-secret branch from 13aea0d to 2f2ea63 Compare June 12, 2016 05:09
@eagletmt
Copy link
Collaborator Author

added a comment

@eagletmt eagletmt merged commit 78c4edb into sorah:master Jun 12, 2016
@eagletmt eagletmt deleted the retry-load-secret branch June 12, 2016 05:11
sorah added a commit that referenced this pull request Jun 12, 2016
== Bug fixes

* Fix SEGV when there's no default collection #10
* Fix build error on a compiler with --as-needed turned on by default #11
* Workaround for occasionally secret retrieval error with libsecret #9
* $LDFLAGS was not honored properly, due to a typo #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants