Skip to content

Support D-Bus secret service via libsecret#7

Merged
eagletmt merged 1 commit intosorah:masterfrom
eagletmt:linux
Jun 8, 2016
Merged

Support D-Bus secret service via libsecret#7
eagletmt merged 1 commit intosorah:masterfrom
eagletmt:linux

Conversation

@eagletmt
Copy link
Collaborator

@eagletmt eagletmt commented Jun 7, 2016

  • Extract platform-independent API:
    • envchain_search_namespaces
    • envchain_search_values
    • envchain_save_values
  • Implement those APIs for Linux using D-Bus secret service

envchain_linux.c Outdated

void envchain_save_value(const char *name, const char *key, char *value,
G_GNUC_UNUSED int require_passphrase) {
/* TODO: Support require_passphrase flag */
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is possible or not

@sorah
Copy link
Owner

sorah commented Jun 7, 2016

lgtm?

@eagletmt eagletmt force-pushed the linux branch 2 times, most recently from 869a20c to 447c038 Compare June 7, 2016 12:34
@eagletmt
Copy link
Collaborator Author

eagletmt commented Jun 7, 2016

I believe it's working well now.
It automatically show prompt requesting to unlock the default collection.

@sorah
Copy link
Owner

sorah commented Jun 7, 2016

LGTM

- Extract platform-independent API:
  - envchain_search_namespaces
  - envchain_search_values
  - envchain_save_values
- Implement those APIs for Linux using D-Bus secret service
@eagletmt
Copy link
Collaborator Author

eagletmt commented Jun 8, 2016

squashed

@eagletmt eagletmt merged commit af16d2f into sorah:master Jun 8, 2016
@eagletmt eagletmt deleted the linux branch June 8, 2016 10:26
sorah added a commit that referenced this pull request Jun 8, 2016
= New feature

- Linux support with libsecret (#7 @eagletmt)

  libsecret commuicates with D-Bus secret service; for instance,
  gnome-keyring implements it.

= New feature in v0.2.0 (forgot to note..)

- `--list` command

  On OS X keychain, values have to be set after envchain v0.2.0 or later
  due to data structure change, in prior to be listed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants