avoid "undefined reference to" error by sorah · Pull Request #11 · sorah/envchain

sorah · 2016-06-11T21:50:00Z

Fix error on my ubuntu 16.04 box:

sorah@debuild-001:~/packages/envchain/envchain$ gcc --version
gcc (Ubuntu 5.3.1-14ubuntu2.1) 5.3.1 20160413
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

sorah@debuild-001:~/packages/envchain/envchain$ make
cc  -lreadline `pkg-config --libs libsecret-1` -o envchain envchain.o envchain_linux.o
envchain.o: In function `envchain_ask_value':
/mnt/vol/home/packages/envchain/envchain/envchain.c:130: undefined reference to `readline'
envchain_linux.o: In function `search_unlocked_collection':
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:20: undefined reference to `secret_service_get_sync'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:26: undefined reference to `secret_collection_for_alias_sync'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:29: undefined reference to `g_object_unref'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:34: undefined reference to `secret_collection_get_locked'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:35: undefined reference to `g_list_append'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:38: undefined reference to `secret_collection_get_service'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:37: undefined reference to `secret_service_unlock_sync'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:40: undefined reference to `g_list_free'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:41: undefined reference to `g_list_free'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:42: undefined reference to `g_object_unref'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:51: undefined reference to `secret_service_disconnect'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:52: undefined reference to `secret_service_get_sync'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:57: undefined reference to `secret_collection_for_alias_sync'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:60: undefined reference to `g_object_unref'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:66: undefined reference to `g_free'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:66: undefined reference to `g_str_equal'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:66: undefined reference to `g_str_hash'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:66: undefined reference to `g_hash_table_new_full'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:69: undefined reference to `g_strdup'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:69: undefined reference to `g_strdup'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:69: undefined reference to `g_hash_table_insert'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:71: undefined reference to `secret_collection_search_sync'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:75: undefined reference to `g_hash_table_unref'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:76: undefined reference to `g_object_unref'
envchain_linux.o: In function `envchain_search_namespaces':
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:89: undefined reference to `g_error_free'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:94: undefined reference to `g_free'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:94: undefined reference to `g_str_equal'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:94: undefined reference to `g_str_hash'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:94: undefined reference to `g_hash_table_new_full'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:106: undefined reference to `g_hash_table_unref'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:107: undefined reference to `g_list_free'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:103: undefined reference to `g_hash_table_unref'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:98: undefined reference to `secret_item_get_attributes'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:99: undefined reference to `g_hash_table_lookup'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:99: undefined reference to `g_strdup'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:100: undefined reference to `g_hash_table_add'
envchain_linux.o: In function `envchain_search_values':
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:118: undefined reference to `g_error_free'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:125: undefined reference to `secret_item_get_attributes'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:126: undefined reference to `g_hash_table_lookup'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:127: undefined reference to `secret_item_get_secret'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:128: undefined reference to `secret_value_get_text'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:129: undefined reference to `secret_value_unref'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:130: undefined reference to `g_hash_table_unref'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:133: undefined reference to `g_list_free'
envchain_linux.o: In function `envchain_save_value':
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:148: undefined reference to `secret_password_store_sync'
/mnt/vol/home/packages/envchain/envchain/envchain_linux.c:154: undefined reference to `g_error_free'
collect2: error: ld returned 1 exit status
Makefile:17: recipe for target 'envchain' failed
make: *** [envchain] Error 1

sorah · 2016-06-11T21:53:36Z

doesn't repro on my Gentoo box (gcc-4.9.3), no difference in pkg-config --libs libsecret-1

6:53 ~/git/github.com/sorah/envchain (▰╹◡╹) make
cc -c -Wall -Wextra -ansi -pedantic -std=c99 `pkg-config --cflags libsecret-1`  -o envchain.o envchain.c
cc -c -Wall -Wextra -ansi -pedantic -std=c99 `pkg-config --cflags libsecret-1`  -o envchain_linux.o envchain_linux.c
cc  -lreadline `pkg-config --libs libsecret-1` -o envchain envchain.o envchain_linux.o

6:53 ~/git/github.com/sorah/envchain (▰╹◡╹) cc --version
gcc (Gentoo 4.9.3 p1.5, pie-0.6.4) 4.9.3
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

eagletmt · 2016-06-12T04:27:15Z

That's because Ubuntu's gcc passes --as-needed by default.
👍 for this change. Thanks.

sorah · 2016-06-12T04:59:46Z

Merging.

P.S. I want to release 1.0.1 tonight, so please merge your bug fixes within this few hours 🙏

== Bug fixes * Fix SEGV when there's no default collection #10 * Fix build error on a compiler with --as-needed turned on by default #11 * Workaround for occasionally secret retrieval error with libsecret #9 * $LDFLAGS was not honored properly, due to a typo #12

avoid "undefined reference to" error

45a2186

sorah merged commit 9c780ab into master Jun 12, 2016

sorah deleted the undefref branch June 12, 2016 05:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

avoid "undefined reference to" error#11

avoid "undefined reference to" error#11
sorah merged 1 commit intomasterfrom
undefref

sorah commented Jun 11, 2016

Uh oh!

sorah commented Jun 11, 2016 •

edited

Loading

Uh oh!

eagletmt commented Jun 12, 2016

Uh oh!

sorah commented Jun 12, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sorah commented Jun 11, 2016

Uh oh!

sorah commented Jun 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eagletmt commented Jun 12, 2016

Uh oh!

sorah commented Jun 12, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sorah commented Jun 11, 2016 •

edited

Loading