Skip to content

Fix issue #1577, and port test cases for issue #1577#2047

Merged
StevenArzt merged 3 commits intosoot-oss:developfrom
Momo-Not-Emo:fix/issue-1577
Feb 12, 2024
Merged

Fix issue #1577, and port test cases for issue #1577#2047
StevenArzt merged 3 commits intosoot-oss:developfrom
Momo-Not-Emo:fix/issue-1577

Conversation

@Momo-Not-Emo
Copy link
Copy Markdown
Contributor

@Momo-Not-Emo Momo-Not-Emo commented Feb 8, 2024 •
edited
Loading

Changes Made:

This fix and test cases are ported from the SootUp PR #405.

Additional Context:

  • A previous PR (Fix crashes in AsmMethodSource(#1577,#1580) #1579) attempting to address these issues was closed due to the lack of test cases. The need for test cases is emphasized to avoid a similar scenario.
  • The decision to include the fix and test cases from SootUp PR #405 is based on their relevance and alignment with the reported issues.

Testing:

All test cases pass successfully when running the following commands locally:

mvn -B clean test -PJava8
mvn -B clean test -PJava9
mvn -B clean test -PJava11

@Momo-Not-Emo
fix issue #1577, and port test cases for issue #1577 and #1580
41f7b8e
@Momo-Not-Emo
Merge branch 'develop' into fix/issue-1577
889126c
@Momo-Not-Emo
add headers
10f53d7 
and remove failed adapted test case for issue 1580, which failed and is ignored in SootUp (with explanation "Localsplitter fails; bytecode itself is somehow strange")
@Momo-Not-Emo Momo-Not-Emo changed the title Fix issue #1577, and port test cases for issue #1577 and #1580 Fix issue #1577, and port test cases for issue #1577 Feb 10, 2024
@Momo-Not-Emo
Copy link
Copy Markdown
Contributor Author

Momo-Not-Emo commented Feb 10, 2024

@StevenArzt Could you review my code?

@StevenArzt StevenArzt merged commit 29e7437 into soot-oss:develop Feb 12, 2024
@StevenArzt
Copy link
Copy Markdown
Contributor

StevenArzt commented Feb 12, 2024

Thank you for your contribution. I had already looked at the code, but somehow forgot to merge after the CI/CD pipeline completed successfully.

@Momo-Not-Emo Momo-Not-Emo mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Momo-Not-Emo @StevenArzt