Fix crashes in AsmMethodSource(#1577,#1580)#1579
Closed
FXTi wants to merge 4 commits intosoot-oss:developfrom
FXTi:issue1577
Closed
Fix crashes in AsmMethodSource(#1577,#1580)#1579FXTi wants to merge 4 commits intosoot-oss:developfrom FXTi:issue1577
FXTi wants to merge 4 commits intosoot-oss:developfrom
FXTi:issue1577
Conversation
FXTi
changed the title
Member
|
This fix doesn't look so trivial. Can you provide unit tests? |
Author
|
No, but I recommend add some unit tests for this pr. |
Member
|
@FXTi Will you add the tests? If you add the tests, I can review this PR. |
Member
|
@swissiety Can you add the two test cases into soot and see if the bugs are still there? If it is the case, make a pull request with the tests and mark them as ignored at first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #1577
mergeIn()should resolve the rightstack_n := @caughtExceptionwhennopforInlineExceptionHandlerappears.UnitContainermay appear instead ofnopforInlineExceptionHandler.Fix: #1580
Edge.stackwithEdge.stacksand keepstacks in the same order asedges inworklist.