issue-982 : Assign TopType to ObjectType at end of TypeAssigner#997
Merged
issue-982 : Assign TopType to ObjectType at end of TypeAssigner#997
Conversation
stschott
requested changes
Jul 29, 2024
Collaborator
There was a problem hiding this comment.
Please isolate the issue and provide a source/class file pair instead of a class from a different library.
Collaborator
Author
There was a problem hiding this comment.
I have added that test case as well, I will remove this class from a diff lib.
JonasKlauke
reviewed
Jul 29, 2024
| c = a; | ||
| } catch (ArithmeticException ex) { | ||
| } | ||
| System.out.println(a); |
Collaborator
There was a problem hiding this comment.
remove println from the testcases. It unnecessary blows up the tests
stschott
approved these changes
Jul 30, 2024
sahilagichani14
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assign TopType to ObjectType at the end of TypeAssigner so LocalNameStandardizer doesn't give exception after.