Issue 988 type assigner warning if no rt.jar found#989
Merged
Conversation
Collaborator
Author
|
This is the case when running type assigner without rt.jar and reaching a situation where no SuperClass of exception class could be found. So warn about no rt.jar present |
sahilagichani14
changed the title
Collaborator
Author
|
dependent on the bug fix, issue-975-typeresolver. once issue fix 975 is merged this would also pass |
…Location() in inputlocation
Contributor
sahilagichani14
force-pushed
the
issue-988-TypeAssigner
branch
from
c2e0bbe to
2336e6e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #989 +/- ##
=============================================
- Coverage 70.34% 70.30% -0.05%
- Complexity 4167 4203 +36
=============================================
Files 316 317 +1
Lines 15658 15736 +78
Branches 2682 2701 +19
=============================================
+ Hits 11015 11063 +48
- Misses 3780 3806 +26
- Partials 863 867 +4 ☔ View full report in Codecov by Sentry. |
stschott
requested changes
Jul 29, 2024
...bytecode/src/test/java/sootup/java/bytecode/interceptors/typeresolving/TypeResolverTest.java
Outdated
Show resolved
Hide resolved
JonasKlauke
reviewed
Jul 29, 2024
Collaborator
JonasKlauke
left a comment
JonasKlauke
left a comment
There was a problem hiding this comment.
mmh the testcase should test the warning, it should not be a visual test by the developer
...bytecode/src/test/java/sootup/java/bytecode/interceptors/typeresolving/TypeResolverTest.java
Outdated
Show resolved
Hide resolved
...bytecode/src/test/java/sootup/java/bytecode/interceptors/typeresolving/TypeResolverTest.java
Outdated
Show resolved
Hide resolved
stschott
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.