Rework the call graph algorithm to annote call edges with the corresponding invoke statement by JonasKlauke · Pull Request #936 · soot-oss/SootUp

JonasKlauke · 2024-05-17T12:34:23Z

introduces Invokable Statements on edges of the call graph to know the target of a specific invokable statement. closes Code line numbers in call-graphs. #483
moves clinit invokes from the constructor invoke to corresponding new statements before the call, to support clinit calls caused by arrays or multiarrys
call graphs will save a list entry methods
clinit calls of given start methods are added to the entry methods of a call graphs
the edge between a starting method and their corresponding clinit method was removed fixes Unexpected Clinit calls in the call graph #902
added test for bug report An inconsistency between call graphs #903, fixes An inconsistency between call graphs #903

…e target of a specific invokable statement

JonasKlauke · 2024-05-17T12:36:13Z

entry methods wont contain anymore an edge to the clinit method.
clinit methods will be added as new entry points to the call graph.
fixes #902

github-actions · 2024-05-17T14:55:58Z

Documentation Preview.

…mt test

…etInvokeExpr

…ement to support newarray and newmultiarray

…newarray or newmultiarray expression

…e call graph. Added a test for multiple calling sides of same methods

… stmt

swissiety

I'm not sure about introducing all these TestUtil classes - Currently it seems/feels like it is creating a lot of additional clutter which does make understanding tests more complicated.. maybe we can reiterate that and have a look how other projects solve it, especially as of the current implementation we can't share those classes across the submodules and would have code duplicates.

sootup.analysis/src/main/java/sootup/analysis/interprocedural/icfg/CGEdgeUtil.java

swissiety · 2024-05-24T14:53:34Z

...up.analysis/src/test/java/sootup/analysis/interprocedural/ifds/IFDSTaintAnalysisProblem.java

      @Override
      public FlowFunction<Value> getCallToReturnFlowFunction(Stmt callSite, Stmt returnSite) {
-        return getCallToReturnFlow(callSite, returnSite);
+        return getCallToReturnFlow((InvokableStmt) callSite, returnSite);


can we adapt heros to have different generic types for callSite Stmts and the other Stmts?

I did not touch the analysis stuff. I made it only work for the current state. I will add an issue for the complete adaption. Or should this PR also contain the adaption to analysis?

I created #937

sootup.callgraph/src/main/java/sootup/callgraph/AbstractCallGraphAlgorithm.java

sootup.core/src/main/java/sootup/core/jimple/common/stmt/InvokableStmt.java

sootup.core/src/main/java/sootup/core/types/ArrayType.java

…heck for static initializer calls

# Conflicts: # sootup.callgraph/src/main/java/sootup/callgraph/AbstractCallGraphAlgorithm.java # sootup.callgraph/src/main/java/sootup/callgraph/RapidTypeAnalysisAlgorithm.java # sootup.tests/src/test/java/sootup/tests/CallGraphTest.java

# Conflicts: # sootup.callgraph/src/main/java/sootup/callgraph/RapidTypeAnalysisAlgorithm.java # sootup.core/src/main/java/sootup/core/jimple/common/expr/JNewMultiArrayExpr.java # sootup.tests/pom.xml

sootup.core/src/main/java/sootup/core/jimple/common/stmt/InvokableStmt.java

# Conflicts: # sootup.callgraph/src/main/java/sootup/callgraph/CallGraph.java

done

introduces Invokable Statements on edges of the call graph to know th…

1553caa

…e target of a specific invokable statement

JonasKlauke added 6 commits May 17, 2024 15:00

util function to get a get a specific invoke stmt for testing

4815002

applied API changes

324ab07

fixed Javadoc

951df14

fmt

587c077

adapted test to new invokable stmt

cb74d71

fixed compile issues caused by API changes

ece4097

JonasKlauke added 20 commits May 17, 2024 16:56

removed wrong deprecated tag on method

1f65974

fixed comparison of Optionals instead of the content in the invoke st…

0acc12c

…mt test

fixed warnings

5c39930

fixed core testcases caused by the invoke expression changes

6bbd674

adapted the jimple comparator to the optional in returned by method g…

21e57da

…etInvokeExpr

added getEntryMethod to the Callgraph Interface

31da35b

fixed warnings

fbd6300

added new util method to get assignment statements with static fields

dacacaf

added new util method to get assignment statements with static fields

1d3f900

moved clinit calls of constructor calls to the corresponding new stat…

063f8b9

…ement to support newarray and newmultiarray

assignment statements can invoke a clinit call if it contains a new, …

7927058

…newarray or newmultiarray expression

fixed warnings

dec114f

added method to check if an array is an array of primitives

0b010d3

fixed warnings

a2b0c39

adapted all sootup.callgraph tests to the new invoke statements in th…

4f25d06

…e call graph. Added a test for multiple calling sides of same methods

improved call graphs tests

1188598

adapted sootup.tests to the changes in the call graph algorithm

f0fedce

simplified util method in CallGraphTest

fdc5f58

removed left op flag from the method that will grab the first fitting…

2ed9606

… stmt

fmt

66706fb

JonasKlauke marked this pull request as ready for review May 24, 2024 14:13

JonasKlauke requested a review from swissiety May 24, 2024 14:20

swissiety previously requested changes May 24, 2024

View reviewed changes

JonasKlauke added 4 commits May 27, 2024 12:27

shorter method names

6e871e7

made isArrayTypeOfPrimitives public static

c5c28bb

removed duplicate dependency

189962b

introduced invokesStaticInitializer by adapting doesInvokes to only c…

bb1baa3

…heck for static initializer calls

JonasKlauke mentioned this pull request May 27, 2024

An inconsistency between call graphs #903

Closed

JonasKlauke added 8 commits May 27, 2024 16:00

added testcase for bug report 903

c42a253

fmt

531b25a

fmt

4529219

added isInvokableStmt and asInvokableStmt to the Stmt API

796dc7d

fixed warnings

02907b0

moved all Util methods into one class

38bd53e

Merge remote-tracking branch 'origin/develop' into feature/InvokesCG

47f0e16

# Conflicts: # sootup.callgraph/src/main/java/sootup/callgraph/RapidTypeAnalysisAlgorithm.java # sootup.core/src/main/java/sootup/core/jimple/common/expr/JNewMultiArrayExpr.java # sootup.tests/pom.xml

kadirayk reviewed Jul 15, 2024

View reviewed changes

sootup.core/src/main/java/sootup/core/jimple/common/stmt/InvokableStmt.java Show resolved Hide resolved

JonasKlauke added 5 commits July 15, 2024 18:29

adapted qilin to the Callgraph API

c7fcbe9

removed unnecessary import

856a318

roll back edge class

a8e125d

Merge remote-tracking branch 'origin/develop' into feature/InvokesCG

9378770

# Conflicts: # sootup.callgraph/src/main/java/sootup/callgraph/CallGraph.java

clean up after merge

8028c0e

kadirayk approved these changes Jul 25, 2024

View reviewed changes

JonasKlauke merged commit 3a03fa0 into develop Jul 25, 2024

JonasKlauke deleted the feature/InvokesCG branch July 25, 2024 13:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rework the call graph algorithm to annote call edges with the corresponding invoke statement#936

Rework the call graph algorithm to annote call edges with the corresponding invoke statement#936
JonasKlauke merged 44 commits intodevelopfrom
feature/InvokesCG

JonasKlauke commented May 17, 2024 •

edited

Loading

Uh oh!

JonasKlauke commented May 17, 2024

Uh oh!

github-actions bot commented May 17, 2024 •

edited

Loading

Uh oh!

swissiety left a comment

Uh oh!

Uh oh!

swissiety May 24, 2024

Uh oh!

JonasKlauke May 27, 2024

Uh oh!

JonasKlauke May 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

JonasKlauke commented May 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonasKlauke commented May 17, 2024

Uh oh!

github-actions bot commented May 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swissiety left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

swissiety May 24, 2024

Choose a reason for hiding this comment

Uh oh!

JonasKlauke May 27, 2024

Choose a reason for hiding this comment

Uh oh!

JonasKlauke May 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JonasKlauke commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading