Skip to content

fix StmtGraph.replaceNode(sameStmt, sameStmt) and Stmt.withNewUse()#885

Merged
kadirayk merged 3 commits intodevelopfrom
fix/CopyPropagator_n_withNewUse
Mar 5, 2024
Merged

fix StmtGraph.replaceNode(sameStmt, sameStmt) and Stmt.withNewUse()#885
kadirayk merged 3 commits intodevelopfrom
fix/CopyPropagator_n_withNewUse

Conversation

@swissiety
Copy link
Copy Markdown
Collaborator

@swissiety swissiety commented Mar 1, 2024

  • consistently return the former stmt instead of null
  • MutableBlockStmtGraph.replaceNode() failed maintaining index datastructures when replacing a stmt with itself

@swissiety swissiety requested a review from kadirayk March 1, 2024 21:00
@swissiety swissiety force-pushed the fix/CopyPropagator_n_withNewUse branch from 70658d8 to 1d68837 Compare March 1, 2024 21:09
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 69.95%. Comparing base (e63dc81) to head (1d68837).

Files Patch % Lines
.../java/sootup/core/graph/MutableBlockStmtGraph.java 0.00% 1 Missing and 1 partial ⚠️
...tup/core/jimple/visitor/ReplaceUseStmtVisitor.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #885      +/-   ##
=============================================
+ Coverage      69.88%   69.95%   +0.06%     
- Complexity      4039     4042       +3     
=============================================
  Files            310      310              
  Lines          15248    15245       -3     
  Branches        2605     2602       -3     
=============================================
+ Hits           10656    10664       +8     
+ Misses          3735     3727       -8     
+ Partials         857      854       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissiety swissiety changed the title fix CopyPropagator and Stmt.withNewUse() fix StmtGraph.replaceNode(sameStmt, sameStmt) and Stmt.withNewUse() Mar 2, 2024
@kadirayk kadirayk merged commit 239d93d into develop Mar 5, 2024
@kadirayk kadirayk deleted the fix/CopyPropagator_n_withNewUse branch March 5, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants