precompute hashCode for JavaClassType and SootClassMemberSignature#881
Merged
swissiety merged 1 commit intosoot-oss:developfrom Feb 28, 2024
Merged
precompute hashCode for JavaClassType and SootClassMemberSignature#881swissiety merged 1 commit intosoot-oss:developfrom
swissiety merged 1 commit intosoot-oss:developfrom
Conversation
swissiety
approved these changes
Feb 28, 2024
Collaborator
swissiety
left a comment
swissiety
left a comment
There was a problem hiding this comment.
👍 this seems very reasonable.
I think its not really necessary to do it on demand like its proposed in effective Java reference on Stackoverflow as we use those methods basically all the time as keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could look weird.
In my use case, I am using
MethodSignatureas key for caches likeMap<MethodSignature, xxx>and found out that when doing code analysis, the cache is frequently read and about 15% of time is spent onhashCode().Since
MethodSignatureandJavaClassTypeare immutable, the hashCode will not change so I cache them in this PR.