replace locals in body builder after types are resolved#877
Merged
swissiety merged 3 commits intosoot-oss:developfrom Feb 28, 2024
Merged
replace locals in body builder after types are resolved#877swissiety merged 3 commits intosoot-oss:developfrom
swissiety merged 3 commits intosoot-oss:developfrom
Conversation
swissiety
approved these changes
Feb 28, 2024
...ava.bytecode/src/main/java/sootup/java/bytecode/interceptors/typeresolving/TypeResolver.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #877 +/- ##
=============================================
+ Coverage 68.26% 68.53% +0.27%
- Complexity 3877 3889 +12
=============================================
Files 311 311
Lines 15186 15195 +9
Branches 2587 2589 +2
=============================================
+ Hits 10366 10414 +48
+ Misses 3911 3880 -31
+ Partials 909 901 -8 ☔ View full report in Codecov by Sentry. |
…eptors/typeresolving/TypeResolver.java change only if needed (which should be the case most of the time)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the end of
TypeResolver.resolve()method, all local types are resolved, however, only theSet<Local> localsof theBodyis replaced with a set of locals with types, without replacing the new locals in each statement.SootUp/sootup.java.bytecode/src/main/java/sootup/java/bytecode/interceptors/typeresolving/TypeResolver.java
Line 98 in 9716b4a
This resulted in the locals in most
Stmts still lacking type information after applying the TypeAssigner. This pull request fixes this issue.