Skip to content

Streamification of getUses() and ...Defs()#862

Merged
kadirayk merged 1 commit intodevelopfrom
enhance/387_Streamify_getUses_Def_s
Feb 23, 2024
Merged

Streamification of getUses() and ...Defs()#862
kadirayk merged 1 commit intodevelopfrom
enhance/387_Streamify_getUses_Def_s

Conversation

@swissiety
Copy link
Copy Markdown
Collaborator

@swissiety swissiety commented Feb 20, 2024

closes #387

@swissiety swissiety force-pushed the enhance/387_Streamify_getUses_Def_s branch 4 times, most recently from 667a41f to b3b79a3 Compare February 20, 2024 16:08
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 20, 2024 •
edited
Loading

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (b0820a3) 68.71% compared to head (6a68598) 67.92%.

Files Patch % Lines
...ode/interceptors/StaticSingleAssignmentFormer.java 0.00% 25 Missing ⚠️
...main/java/sootup/core/validation/NewValidator.java 53.84% 4 Missing and 2 partials ⚠️
...ytecode/interceptors/DeadAssignmentEliminator.java 0.00% 5 Missing ⚠️
...tecode/interceptors/typeresolving/CastCounter.java 25.00% 0 Missing and 3 partials ⚠️
.../java/sootup/core/jimple/common/expr/JPhiExpr.java 0.00% 2 Missing ⚠️
...tup.core/src/main/java/sootup/core/model/Body.java 90.00% 0 Missing and 2 partials ⚠️
...sootup/java/bytecode/interceptors/LocalPacker.java 71.42% 0 Missing and 2 partials ⚠️
.../src/main/java/sootup/core/jimple/basic/Local.java 66.66% 0 Missing and 1 partial ⚠️
...p/java/bytecode/frontend/AsmJavaClassProvider.java 50.00% 1 Missing ⚠️
...sootup/java/bytecode/frontend/AsmMethodSource.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop     #862      +/-   ##
=============================================
- Coverage      68.71%   67.92%   -0.80%     
+ Complexity      3846     3809      -37     
=============================================
  Files            309      309              
  Lines          15207    15159      -48     
  Branches        2578     2567      -11     
=============================================
- Hits           10450    10296     -154     
- Misses          3873     3953      +80     
- Partials         884      910      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissiety
Streamification of getUses() and fix formerly known List<> getDefs().…
6a68598 
…. jimple is 3 address code! no multiple defs ;-) its now OPtional<LValue> getDef()
@swissiety swissiety force-pushed the enhance/387_Streamify_getUses_Def_s branch from b3b79a3 to 6a68598 Compare February 20, 2024 16:42
@kadirayk kadirayk merged commit fee3451 into develop Feb 23, 2024
@kadirayk kadirayk deleted the enhance/387_Streamify_getUses_Def_s branch February 23, 2024 10:01
@swissiety swissiety mentioned this pull request Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kadirayk kadirayk kadirayk approved these changes

@stschott stschott Awaiting requested review from stschott

@JonasKlauke JonasKlauke Awaiting requested review from JonasKlauke

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

elaborate Value.getUses() - use the Stream API

2 participants

@swissiety @kadirayk