Migrate test system from junit 4 to junit 5#856
Merged
Conversation
Contributor
|
You updated the documentation - Doc Preview. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #856 +/- ##
=============================================
- Coverage 68.11% 67.91% -0.20%
+ Complexity 3852 3848 -4
=============================================
Files 310 310
Lines 15225 15225
Branches 2590 2590
=============================================
- Hits 10370 10340 -30
- Misses 3941 3965 +24
- Partials 914 920 +6 ☔ View full report in Codecov by Sentry. |
swissiety
requested changes
Feb 16, 2024
Collaborator
swissiety
left a comment
swissiety
left a comment
There was a problem hiding this comment.
good work!
To avoid @Tag problems with typos lets replace @Tag\(\"Java([8|9])\"\) by @Tag(TestCategories.JAVA_$i_CATEGORY) and add a categories class file to each module like its done in the bytecode module ( or can we move it to core and reuse it in the other modules?)
Collaborator
|
just from the added timing in the java8 run (+2minutes) I would assume the testwatcher is not caching?
|
Collaborator
Author
|
I added on many testclasses a Tag which had no category before. That could be the reason. Since we also gained coverage |
Collaborator
Author
|
The Enum Tag is good and yeah we should go for only one Enum. If every module imports core then we can simply put it there |
# Conflicts: # sootup.java.bytecode/src/test/java/sootup/java/bytecode/Soot1577Test.java
# Conflicts: # sootup.core/src/test/java/sootup/core/graph/MutableBasicBlockTest.java # sootup.core/src/test/java/sootup/core/graph/MutableBlockStmtGraphTest.java # sootup.core/src/test/java/sootup/core/jimple/basic/LocalGeneratorTest.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/RuntimeJarConversionTests.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/interceptors/CastAndReturnInlinerTest.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/minimaltestsuite/MinimalBytecodeTestSuiteBase.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/minimaltestsuite/java11/TypeInferenceLambdaTest.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/minimaltestsuite/java15/MultilineStringsTest.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/minimaltestsuite/java6/AnnotationUsageInheritedTest.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/minimaltestsuite/java6/AnnotationUsageTest.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/minimaltestsuite/java6/NestedAnnotationTest.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/minimaltestsuite/java6/VisibleAnnotationTest.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/minimaltestsuite/java9/DynamicInvokeTest.java # sootup.java.core/src/test/java/sootup/java/core/printer/JimplePrinterTest.java # sootup.java.core/src/test/java/sootup/java/core/printer/LegacyJimplePrinterTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/frontend/SwitchConversionTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java10/TypeInferenceTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/AnnotationLibraryTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/CastingInNumTypesTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/DeclareConstructorTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/DeclareFieldTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/DeclareFloatTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/DeclareIntTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/DeclareLongTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/GenTypeParamTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/InstanceOfCheckTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/InterfaceImplClassTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/MethodOverloadingTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/MethodOverridingTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/MultiInterfaceImplClassTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/NativeMethodTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/ReferencingThisTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/ReflectionTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/StaticImportTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/StaticInitializerTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/StaticMethodTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/StaticVariableTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/SubClassTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/SuperClassTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/SynchronizedMethodTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/TernaryOperatorTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/ThrowExceptionMethodTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/TransientVariableTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/UnaryOpIntTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/UncheckedCastTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/UnicodeMethodNameTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/VirtualMethodTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java6/VolatileVariableTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java8/DefaultMethodInterfaceImplTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java8/MethodAcceptingLamExprTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java8/MethodReferenceTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java8/RepeatingAnnotationsTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java8/StaticMethodInterfaceImplTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java9/AnonymousDiamondOperatorTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java9/PrivateMethodInterfaceImplTest.java # sootup.java.sourcecode/src/test/java/sootup/java/sourcecode/minimaltestsuite/java9/TryWithResourcesConciseTest.java # sootup.jimple.parser/src/test/java/sootup/jimple/parser/javatestsuite/java9/DynamicInvokeTest.java # sootup.tests/src/test/java/sootup/tests/WitherTest.java
Collaborator
Author
|
Enum moved to #859 |
# Conflicts: # sootup.tests/src/test/java/sootup/tests/ReplaceUseExprVisitorTest.java # sootup.tests/src/test/java/sootup/tests/ReplaceUseRefVisitorTest.java # sootup.tests/src/test/java/sootup/tests/ReplaceUseStmtVisitorTest.java
swissiety
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update all tests to the API changes in juint 5