Skip to content

Refactor/new localsplitter#848

Merged
kadirayk merged 3 commits intodevelopfrom
refactor/NewLocalsplitter
Feb 12, 2024
Merged

Refactor/new localsplitter#848
kadirayk merged 3 commits intodevelopfrom
refactor/NewLocalsplitter

Conversation

@swissiety
Copy link
Copy Markdown
Collaborator

@swissiety swissiety commented Feb 8, 2024

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2024 •
edited
Loading

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (954e20d) 64.20% compared to head (b42b33a) 64.11%.

❗ Current head b42b33a differs from pull request most recent head 71a9bd7. Consider uploading reports for the commit 71a9bd7 to get more accurate results

Files Patch % Lines
...otup/java/bytecode/interceptors/LocalSplitter.java 77.77% 4 Missing and 6 partials ⚠️
...a/sootup/callgraph/AbstractCallGraphAlgorithm.java 55.00% 3 Missing and 6 partials ⚠️
.../java/sootup/core/jimple/basic/LocalGenerator.java 86.44% 5 Missing and 3 partials ⚠️
...n/java/sootup/java/core/JavaIdentifierFactory.java 0.00% 2 Missing and 6 partials ⚠️
...tup/callgraph/ClassHierarchyAnalysisAlgorithm.java 42.85% 1 Missing and 3 partials ⚠️
...n/java/sootup/java/core/views/MutableJavaView.java 0.00% 2 Missing and 2 partials ⚠️
...procedural/icfg/JimpleBasedInterproceduralCFG.java 0.00% 1 Missing and 1 partial ⚠️
...a/sootup/callgraph/RapidTypeAnalysisAlgorithm.java 0.00% 1 Missing and 1 partial ⚠️
...a/sootup/core/cache/provider/LRUCacheProvider.java 0.00% 1 Missing and 1 partial ⚠️
...e/src/main/java/sootup/core/jimple/basic/Trap.java 50.00% 1 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop     #848      +/-   ##
=============================================
- Coverage      64.20%   64.11%   -0.09%     
+ Complexity      3436     3432       -4     
=============================================
  Files            312      312              
  Lines          15059    15103      +44     
  Branches        2546     2546              
=============================================
+ Hits            9668     9684      +16     
- Misses          4485     4514      +29     
+ Partials         906      905       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissiety
be more tolerant and handle the case that Locals already contain a '#…
71a9bd7 
…' - do a collision check on the generated Local
@swissiety swissiety force-pushed the refactor/NewLocalsplitter branch from b42b33a to 71a9bd7 Compare February 9, 2024 11:55
@kadirayk kadirayk merged commit 4dd5bdb into develop Feb 12, 2024
@kadirayk kadirayk deleted the refactor/NewLocalsplitter branch February 12, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kadirayk kadirayk kadirayk approved these changes

@stschott stschott Awaiting requested review from stschott

@JonasKlauke JonasKlauke Awaiting requested review from JonasKlauke

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swissiety @kadirayk