fix cast error for Operands with side effects#846
Merged
swissiety merged 1 commit intosoot-oss:developfrom Feb 8, 2024
Merged
Conversation
`Operand`s that can be used as both a statement and an expression could throw a cast exception. This was not noticed earlier because `AsmMethodSource::getStmt` is generic and therefore no actual cast was visible in the source code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #846 +/- ##
=============================================
+ Coverage 63.74% 64.05% +0.31%
- Complexity 3417 3435 +18
=============================================
Files 312 312
Lines 15086 15087 +1
Branches 2559 2559
=============================================
+ Hits 9616 9664 +48
+ Misses 4557 4513 -44
+ Partials 913 910 -3 ☔ View full report in Codecov by Sentry. |
swissiety
approved these changes
Feb 8, 2024
Collaborator
swissiety
left a comment
swissiety
left a comment
There was a problem hiding this comment.
Nice. Thx for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operands that can be used as both a statement and an expression could throw a cast exception. This was not noticed earlier becauseAsmMethodSource::getStmtis generic and therefore no actual cast was visible in the source code.I also added a testcase for this behavior.
(This was originally discovered while working on #841 in the method
<java.net.URI: java.lang.String decode(java.lang.String,boolean)>)