fix TypeResolver using field references incorrectly#825
Merged
JonasKlauke merged 1 commit intosoot-oss:developfrom Jan 22, 2024
Merged
fix TypeResolver using field references incorrectly#825JonasKlauke merged 1 commit intosoot-oss:developfrom
JonasKlauke merged 1 commit intosoot-oss:developfrom
Conversation
Assignments to fields of locals shouldn't change the types of the locals themselves.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #825 +/- ##
=============================================
+ Coverage 63.61% 63.69% +0.08%
- Complexity 3431 3435 +4
=============================================
Files 313 313
Lines 15161 15159 -2
Branches 2569 2568 -1
=============================================
+ Hits 9644 9656 +12
+ Misses 4610 4597 -13
+ Partials 907 906 -1 ☔ View full report in Codecov by Sentry. |
JonasKlauke
approved these changes
Jan 22, 2024
Collaborator
JonasKlauke
left a comment
JonasKlauke
left a comment
There was a problem hiding this comment.
Is this done?
looking good
Contributor
Author
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignments to fields of locals shouldn't change the types of the locals themselves.
This was bug was introduced in this commit.
Closes #799