fix immediate inlining over trap ranges#824
Merged
swissiety merged 5 commits intosoot-oss:developfrom Jan 18, 2024
Merged
Conversation
To do this, each `Operand` keeps track of which trap handlers are active at the instruction that it was created. When these active trap handlers differ at the place where the `Operand` is used, it is not inlined.
I didn't test this since I couldn't even think of an example where this makes a difference.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #824 +/- ##
=============================================
+ Coverage 63.57% 63.60% +0.02%
- Complexity 3427 3430 +3
=============================================
Files 313 313
Lines 15145 15161 +16
Branches 2565 2569 +4
=============================================
+ Hits 9629 9643 +14
Misses 4610 4610
- Partials 906 908 +2 ☔ View full report in Codecov by Sentry. |
swissiety
approved these changes
Jan 18, 2024
Collaborator
swissiety
left a comment
swissiety
left a comment
There was a problem hiding this comment.
looks good - thanks :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do this, each
Operandkeeps track of which trap handlers are active at the instruction that it was created.When these active trap handlers differ at the place where the
Operandis used, it is not inlined.Closes #802
Supersedes #803
Monitors should maybe get the same treatment as well, but in practice this shouldn't be an issue because (at least to my knowledge) compilers are required to generate trap ranges over monitor ranges.