Deleting CheckVoidLocalesValidator.java#809
Merged
akshitad11 merged 2 commits intodevelopfrom Jan 11, 2024
Merged
Conversation
…nt to not allow VoidType for locals.
# Conflicts: # sootup.core/src/main/java/sootup/core/validation/CheckVoidLocalesValidator.java
kadirayk
approved these changes
Jan 11, 2024
Member
|
@akshitad11 you probably need to merge the dev branch locally and commit again, it thinks there is a conflict. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #809 +/- ##
=============================================
- Coverage 63.70% 63.70% -0.01%
+ Complexity 3440 3439 -1
=============================================
Files 314 313 -1
Lines 15166 15163 -3
Branches 2568 2568
=============================================
- Hits 9662 9660 -2
+ Misses 4598 4597 -1
Partials 906 906 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local.java has a check present to not allow VoidType for local.