Skip to content

fix #682 from path#738

Merged
swissiety merged 67 commits intodevelopfrom
fix/682_fromPath
Jan 31, 2024
Merged

fix #682 from path#738
swissiety merged 67 commits intodevelopfrom
fix/682_fromPath

Conversation

@swissiety
Copy link
Copy Markdown
Collaborator

@swissiety swissiety commented Nov 2, 2023

  • check if the requested fq classname matches the fq name in the bytecode
  • fix fully qualified Names from JrtFileSystemAnalysisInputLocation Module
  • fix multi release jar package name generation
    - [ ] (re)implement multi release for modules -> Issue implement & test modular MultiReleaseAnalysisInputLocation #823
  • fixed wrong multi-release-jar test input jars
  • fix single class file input location ClassFileBasedAnalysisInputLocation as the packagename is not resolved correctly (i.e. missing)
  • enable license header checks for all sootup modules; add licenses; add own style check pipeline step which takes care of license headers too

closes #682
fixes #675

…or); dont copy StmtGrapg if already not mutable;
# Conflicts:
#	sootup.core/src/main/java/sootup/core/IdentifierFactory.java
#	sootup.java.bytecode/src/main/java/sootup/java/bytecode/interceptors/typeresolving/CastCounter.java
#	sootup.java.bytecode/src/test/java/sootup/java/bytecode/inputlocation/PathBasedAnalysisInputLocationTest.java
#	sootup.java.core/src/main/java/sootup/java/core/JavaIdentifierFactory.java
@swissiety swissiety mentioned this pull request Nov 30, 2023
# Conflicts:
#	sootup.core/src/main/java/sootup/core/model/Body.java
#	sootup.java.bytecode/src/main/java/sootup/java/bytecode/inputlocation/PathBasedAnalysisInputLocation.java
#	sootup.java.bytecode/src/test/java/sootup/java/bytecode/inputlocation/PathBasedAnalysisInputLocationTest.java
#	sootup.jimple.parser/src/main/java/sootup/jimple/parser/JimpleAnalysisInputLocation.java
…romPath

# Conflicts:
#	sootup.java.bytecode/src/test/java/sootup/java/bytecode/inputlocation/PathBasedAnalysisInputLocationTest.java
….. why didn't they fail.. or didnt they just *not* work as intended and therefore did not fail.
# Conflicts:
#	sootup.core/src/main/java/sootup/core/model/Body.java
#	sootup.java.bytecode/src/main/java/sootup/java/bytecode/inputlocation/PathBasedAnalysisInputLocation.java
#	sootup.java.bytecode/src/test/java/sootup/java/bytecode/minimaltestsuite/java14/RecordTest.java
@swissiety swissiety marked this pull request as ready for review January 22, 2024 11:13
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (ee53892) 63.88% compared to head (f139b8e) 63.78%.

Files Patch % Lines
...location/MultiReleaseJarAnalysisInputLocation.java 71.73% 22 Missing and 4 partials ⚠️
.../java/sootup/core/graph/MutableBlockStmtGraph.java 34.61% 15 Missing and 2 partials ⚠️
...on/ModuleMultiReleaseJarAnalysisInputLocation.java 0.00% 12 Missing ⚠️
...tup.core/src/main/java/sootup/core/model/Body.java 46.15% 2 Missing and 5 partials ⚠️
.../inputlocation/PathBasedAnalysisInputLocation.java 86.27% 5 Missing and 2 partials ⚠️
...ava/sourcecode/frontend/WalaJavaClassProvider.java 14.28% 6 Missing ⚠️
...ore/src/main/java/sootup/core/graph/StmtGraph.java 0.00% 2 Missing and 2 partials ⚠️
...p/java/bytecode/frontend/AsmJavaClassProvider.java 76.47% 3 Missing and 1 partial ⚠️
...sootup/java/bytecode/frontend/AsmMethodSource.java 50.00% 2 Missing and 1 partial ⚠️
...ore/jimple/common/expr/AbstractFloatBinopExpr.java 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #738      +/-   ##
=============================================
- Coverage      63.88%   63.78%   -0.10%     
+ Complexity      3438     3414      -24     
=============================================
  Files            313      312       -1     
  Lines          15136    15073      -63     
  Branches        2568     2559       -9     
=============================================
- Hits            9669     9615      -54     
+ Misses          4562     4549      -13     
- Partials         905      909       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissiety swissiety self-assigned this Jan 22, 2024
@swissiety swissiety requested a review from stschott January 26, 2024 16:43
@swissiety swissiety requested a review from kadirayk January 29, 2024 09:27
@swissiety swissiety merged commit d5f593a into develop Jan 31, 2024
@swissiety swissiety deleted the fix/682_fromPath branch January 31, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Fully Qualified Name Resolving for ClassTypes JavaIdentifierFactory's fromPath may crash when handling paths with META-INF

2 participants