Skip to content

NewValidator Changes #733

Merged
kadirayk merged 29 commits intodevelopfrom
validator_changes
Jan 2, 2024
Merged

NewValidator Changes #733
kadirayk merged 29 commits intodevelopfrom
validator_changes

Conversation

@akshitad11
Copy link
Copy Markdown
Contributor

@akshitad11 akshitad11 commented Oct 30, 2023

Refactored NewValidator.java to work with Sootup.
Deleting CheckEscapingValidator.java and ReturnStatementsValidator.java.

@akshitad11
Refactored NewValidator.java to work with Sootup.
1fb79eb 
Deleting CheckEscapingValidator.java and ReturnStatementsValidator.java.
@akshitad11 akshitad11 requested a review from kadirayk October 30, 2023 17:04
@swissiety
Copy link
Copy Markdown
Collaborator

swissiety commented Oct 31, 2023

please execute the maven fmt plugin to adhere to the projects code style

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 2, 2023 •
edited
Loading

Codecov Report

Attention: 96 lines in your changes are missing coverage. Please review.

Comparison is base (129eeb7) 63.78% compared to head (3dd6d09) 63.38%.
Report is 7 commits behind head on develop.

Files Patch % Lines
...main/java/sootup/core/validation/NewValidator.java 0.00% 65 Missing ⚠️
.../bytecode/interceptors/JimpleSemanticsChecker.java 0.00% 12 Missing ⚠️
.../src/main/java/sootup/core/jimple/basic/Local.java 33.33% 1 Missing and 1 partial ⚠️
...java/sootup/core/validation/FieldRefValidator.java 0.00% 2 Missing ⚠️
...n/java/sootup/core/validation/LocalsValidator.java 0.00% 2 Missing ⚠️
...ava/sootup/core/validation/CheckInitValidator.java 0.00% 1 Missing ⚠️
...va/sootup/core/validation/CheckTypesValidator.java 0.00% 1 Missing ⚠️
...tup/core/validation/CheckVoidLocalesValidator.java 0.00% 1 Missing ⚠️
...p/core/validation/IdentityStatementsValidator.java 0.00% 1 Missing ⚠️
...java/sootup/core/validation/IdentityValidator.java 0.00% 1 Missing ⚠️
... and 8 more
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop     #733      +/-   ##
=============================================
- Coverage      63.78%   63.38%   -0.41%     
+ Complexity      3385     3376       -9     
=============================================
  Files            315      314       -1     
  Lines          15017    15074      +57     
  Branches        2534     2557      +23     
=============================================
- Hits            9579     9555      -24     
- Misses          4545     4626      +81     
  Partials         893      893

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kadirayk
kadirayk reviewed Nov 2, 2023
View reviewed changes
sootup.core/src/main/java/sootup/core/validation/NewValidator.java Outdated
*/

import java.util.List;
import java.util.*;
Copy link
Copy Markdown
Member

@kadirayk kadirayk Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need the license headers, you can add your name too.

kadirayk
kadirayk reviewed Nov 2, 2023
View reviewed changes
JonasKlauke
JonasKlauke reviewed Nov 28, 2023
View reviewed changes
akshitad11 and others added 14 commits November 30, 2023 13:30
@akshitad11
Merge branch 'develop' of https://github.com/soot-oss/SootUp into val…
9722c61 
…idator_changes
@akshitad11
validate method signature change
6868bb4
@akshitad11
Merge branch 'develop' of https://github.com/soot-oss/SootUp into val…
2368035 
…idator_changes
@akshitad11
Deleting files, jimple file used for testing
30bde64
@akshitad11
Renaming to handle ambiguity
e7eae50
@akshitad11
Merge branch 'develop' of https://github.com/soot-oss/SootUp into val…
3e99c3a 
…idator_changes
@kadirayk
use equals instead of contains
d8e357a
@kadirayk
move test to integration
8085ac9
@kadirayk
Merge remote-tracking branch 'origin/develop' into validator_changes
7d21bf9
@kadirayk
remove JimpleProject
732bcd3
@kadirayk
remove hardcoded version
8bde134
@akshitad11
Fixing Tests
331d059
@akshitad11
Merge remote-tracking branch 'origin/validator_changes' into validato…
dba836e 
…r_changes
@akshitad11
Merge branch 'develop' into validator_changes
397dcef
kadirayk
kadirayk reviewed Dec 21, 2023
View reviewed changes
@kadirayk kadirayk merged commit bc6f0bc into develop Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonasKlauke JonasKlauke JonasKlauke left review comments

@kadirayk kadirayk kadirayk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@akshitad11 @swissiety @kadirayk @JonasKlauke