not throw exceptions when class of annotation not found#726
Merged
JonasKlauke merged 7 commits intosoot-oss:developfrom Nov 20, 2023
Merged
not throw exceptions when class of annotation not found#726JonasKlauke merged 7 commits intosoot-oss:developfrom
JonasKlauke merged 7 commits intosoot-oss:developfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #726 +/- ##
=============================================
- Coverage 63.95% 63.68% -0.28%
+ Complexity 3424 3342 -82
=============================================
Files 317 317
Lines 15391 15071 -320
Branches 2609 2542 -67
=============================================
- Hits 9844 9598 -246
+ Misses 4639 4588 -51
+ Partials 908 885 -23 ☔ View full report in Codecov by Sentry. |
Liyw979
changed the title
JonasKlauke
requested changes
Nov 20, 2023
Collaborator
JonasKlauke
left a comment
JonasKlauke
left a comment
There was a problem hiding this comment.
Thanks for the small fix. Could you add a warning showing the missing annotation. So User will know that SootUp might need more data.
sootup.java.core/src/main/java/sootup/java/core/types/AnnotationType.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When analysing single jar package, Sootup throws exceptions when some class of the annotation is missing.
In this PR:
getAnnotationssincegetDefaultValuesis called inresolveDefaultsForAnnotationType.getAnnotationswithout the default values.