Skip to content

Optimize/asmmethodsource loop unroll remove necessity to reverse#722

Merged
stschott merged 9 commits intodevelopfrom
optimize/asmmethodsource_loop_unroll_remove_necessity_to_reverse
Oct 27, 2023
Merged

Optimize/asmmethodsource loop unroll remove necessity to reverse#722
stschott merged 9 commits intodevelopfrom
optimize/asmmethodsource_loop_unroll_remove_necessity_to_reverse

Conversation

@swissiety
Copy link
Copy Markdown
Collaborator

@swissiety swissiety commented Oct 26, 2023 •
edited
Loading

improves readability for humans as well

swissiety added 6 commits July 17, 2023 13:43
@swissiety
optimize:
c3fdbe6 
use array (assign entries from high index to low index) and Arrays.toList to remove the necessity of reversing the ArrayList after creation
unify 2 ternary-ifs with equivalent condition to a single if
invert inverted if condition
@swissiety
deprecate methods: Jimple.new*Invoke(..., Immediate .. args) -> use t…
801bc94 
…he version with: List<Immediate> args as parameter instead
@swissiety
Merge branch 'develop' into optimize/asmmethodsource_loop_unroll_remo…
4c43c27 
…ve_necessity_to_reverse

# Conflicts:
#	sootup.java.bytecode/src/main/java/sootup/java/bytecode/frontend/AsmMethodSource.java
@swissiety
fix missing import /merge leftover
985ea7e
@swissiety
optimize: merge ifs; flip ! condition; remove unnecessary empty array…
5e0f7d9 
… init that will not be used if its empty
@swissiety
refactor: merge if
d163bcb
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (baa460f) 65.37% compared to head (5e7d922) 65.35%.
Report is 57 commits behind head on develop.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop     #722      +/-   ##
=============================================
- Coverage      65.37%   65.35%   -0.02%     
+ Complexity      3408     3404       -4     
=============================================
  Files            313      313              
  Lines          14973    14979       +6     
  Branches        2524     2520       -4     
=============================================
+ Hits            9789     9790       +1     
- Misses          4294     4299       +5     
  Partials         890      890
Files Coverage Δ
....core/src/main/java/sootup/core/jimple/Jimple.java 87.23% <ø> (ø)
...sootup/java/bytecode/frontend/AsmMethodSource.java 71.95% <82.97%> (-0.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissiety swissiety requested a review from stschott October 26, 2023 11:24
@stschott stschott merged commit 647da14 into develop Oct 27, 2023
@swissiety swissiety deleted the optimize/asmmethodsource_loop_unroll_remove_necessity_to_reverse branch November 8, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stschott stschott stschott approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swissiety @stschott