Skip to content

unify the parameter order; remove 'convenvience' method with unnecess…#720

Merged
stschott merged 1 commit intodevelopfrom
improve/parameter_order
Oct 25, 2023
Merged

unify the parameter order; remove 'convenvience' method with unnecess…#720
stschott merged 1 commit intodevelopfrom
improve/parameter_order

Conversation

@swissiety
Copy link
Copy Markdown
Collaborator

…ary mix of layers Signatures<->SootClass

@swissiety swissiety requested a review from stschott October 25, 2023 11:55
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62a1d02) 65.37% compared to head (5f6a1cd) 65.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #720   +/-   ##
==========================================
  Coverage      65.37%   65.37%           
  Complexity      3407     3407           
==========================================
  Files            313      313           
  Lines          14974    14973    -1     
  Branches        2524     2524           
==========================================
  Hits            9789     9789           
+ Misses          4295     4294    -1     
  Partials         890      890           
Files Coverage Δ
...n/java/sootup/java/core/JavaIdentifierFactory.java 83.50% <100.00%> (+0.42%) ⬆️
.../sootup/java/core/JavaModuleIdentifierFactory.java 98.14% <ø> (ø)
...java/sourcecode/frontend/InstructionConverter.java 92.27% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stschott stschott merged commit 26cb811 into develop Oct 25, 2023
@swissiety swissiety deleted the improve/parameter_order branch November 8, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants