Conversation
swissiety
reviewed
Oct 5, 2023
| @Nonnull | ||
| @Override | ||
| public Collection<? extends AbstractClassSource<JavaSootClass>> getClassSources(@Nonnull View<?> view) { | ||
| return null; |
Collaborator
There was a problem hiding this comment.
please return the single class in a Collection.singletonList(...) as well
swissiety
reviewed
Oct 5, 2023
...ytecode/src/main/java/sootup/java/bytecode/inputlocation/PathBasedAnalysisInputLocation.java
Outdated
Show resolved
Hide resolved
swissiety
reviewed
Oct 5, 2023
sootup.core/src/main/java/sootup/core/inputlocation/FileType.java
Outdated
Show resolved
Hide resolved
5 tasks
kadirayk
reviewed
Oct 18, 2023
...ytecode/src/main/java/sootup/java/bytecode/inputlocation/PathBasedAnalysisInputLocation.java
Show resolved
Hide resolved
stschott
reviewed
Oct 19, 2023
...ytecode/src/main/java/sootup/java/bytecode/inputlocation/PathBasedAnalysisInputLocation.java
Outdated
Show resolved
Hide resolved
…ocation/PathBasedAnalysisInputLocation.java
stschott
reviewed
Oct 19, 2023
...ytecode/src/main/java/sootup/java/bytecode/inputlocation/PathBasedAnalysisInputLocation.java
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #699 +/- ##
=============================================
- Coverage 64.96% 63.97% -0.99%
- Complexity 3372 3424 +52
=============================================
Files 313 317 +4
Lines 14966 15408 +442
Branches 2525 2612 +87
=============================================
+ Hits 9723 9858 +135
- Misses 4343 4640 +297
- Partials 900 910 +10
☔ View full report in Codecov by Sentry. |
kadirayk
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.