Split Modifiers to resolve flag clashes#661
Merged
JonasKlauke merged 6 commits intodevelopfrom Aug 1, 2023
Merged
Conversation
swissiety
requested changes
Aug 1, 2023
sootup.jimple.parser/src/main/java/sootup/jimple/parser/JimpleConverter.java
Outdated
Show resolved
Hide resolved
sootup.jimple.parser/src/main/java/sootup/jimple/parser/JimpleConverter.java
Outdated
Show resolved
Hide resolved
sootup.jimple.parser/src/main/java/sootup/jimple/parser/JimpleConverter.java
Outdated
Show resolved
Hide resolved
swissiety
approved these changes
Aug 1, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #661 +/- ##
=============================================
- Coverage 65.04% 64.92% -0.12%
- Complexity 3351 3369 +18
=============================================
Files 312 314 +2
Lines 14835 14930 +95
Branches 2473 2493 +20
=============================================
+ Hits 9650 9694 +44
- Misses 4296 4349 +53
+ Partials 889 887 -2
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fields, Classes and Methods have modfiers which have the same bytecode but different meanings
fixes #630
introduces API changes since Modifier is split to different Enums