refactor weird naming PackageName.getPackageName()#646
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #646 +/- ##
=============================================
- Coverage 64.51% 64.49% -0.03%
+ Complexity 3310 3309 -1
=============================================
Files 311 311
Lines 14754 14754
Branches 2451 2451
=============================================
- Hits 9519 9516 -3
- Misses 4352 4354 +2
- Partials 883 884 +1
☔ View full report in Codecov by Sentry. |
stschott
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to getName() which is basically the same as toString() but with getPackageName i would expect the Type again.. which would be weird.