Merged
Conversation
Test written does not make sense, as i am comparing two same strings.
Closed
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #640 +/- ##
=============================================
+ Coverage 64.51% 65.08% +0.57%
- Complexity 3310 3350 +40
=============================================
Files 311 312 +1
Lines 14754 14849 +95
Branches 2451 2473 +22
=============================================
+ Hits 9519 9665 +146
+ Misses 4352 4296 -56
- Partials 883 888 +5
☔ View full report in Codecov by Sentry. |
kadirayk
reviewed
Jul 5, 2023
...alysis/src/main/java/sootup/analysis/interprocedural/icfg/JimpleBasedInterproceduralCFG.java
Outdated
Show resolved
Hide resolved
JonasKlauke
requested changes
Jul 5, 2023
sootup.analysis/src/test/java/sootup/analysis/interprocedural/ifds/ICFGCallGraphTest.java
Outdated
Show resolved
Hide resolved
1. One more test case added 2.ICFGDotExporter moved from core to callgraph module
1. Created a folder ICFG in resources folder to add the files. 2. Converted the CallGraph String into Java Object for test
kadirayk
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test does not seem to make sense, as I am comparing two strings that I know will be the same. I tried the resulting string in the https://dreampuf.github.io/GraphvizOnline/ website to visualize the ICFG. I also attach the resulting png image of the ICFG.
