Merged
Conversation
Member
|
@bastihav thanks! I fixed the callgraph issue. But now we have another ClassCastException in ReplaceUseStmtVisitor |
Contributor
Author
This was referenced Aug 11, 2021
Contributor
Author
Member
This reverts commit 57179a4.
kadirayk
approved these changes
Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kadirayk The callgraph still does not work, but this now seems to be an issue related to the callgraph algorithms, as far as I can tell. Can you take a look at that?
This also includes a proposed (currently under Review) fix in old soot, soot-oss/soot#1579
We should probably add tests for the related issues from old soot, too.