Skip to content

fix insertBefore / implement insertAfter#1141

Merged
swissiety merged 13 commits intodevelopfrom
insertBefore_After
Jan 14, 2025
Merged

fix insertBefore / implement insertAfter#1141
swissiety merged 13 commits intodevelopfrom
insertBefore_After

Conversation

@wangzun66
Copy link
Copy Markdown
Collaborator

@wangzun66 wangzun66 commented Nov 28, 2024 •
edited
Loading

  • insertBefore
  • insert a stmt before a block head stmt with same trap-map
  • insert a stmt before a block head stmt with different trap-map
  • insert a stmt before a block middle/tail stmt with same trap-map
  • insert a stmt before a block middle/tail stmt with different trap-map
  • insertAfter
  • insert a stmt after a block middle/head stmt with same trap-map
  • insert a stmt after a block middle/head stmt with different trap-map
  • insert a stmt after a block tail stmt with same trap-map
  • insert a stmt after a block tail stmt with different trap-map
  • other problems
  • P1: After insertion, Blocks are not merged.
  • P2: After insertion, Information of Traps may be false.
  • P3: Sometimes(maybe with traps), a block could have two same predecessors.

@wangzun66 wangzun66 self-assigned this Nov 28, 2024
This was linked to issues Nov 28, 2024
implement MutableStmtGraph.insertAfter(..) #751
Closed
fix (semantics) of MutableStmtGraph.insertBefore(Stmt existingStmt, FallsThroughStmt newStmt) #873
Closed
@wangzun66 wangzun66 changed the title fix insertBefore/After fix insertBefore / implement insertAfter Nov 28, 2024
@swissiety swissiety merged commit 06a2f63 into develop Jan 14, 2025
@swissiety swissiety deleted the insertBefore_After branch January 14, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissiety swissiety swissiety approved these changes

@stschott stschott Awaiting requested review from stschott

Assignees

@wangzun66 wangzun66

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix (semantics) of MutableStmtGraph.insertBefore(Stmt existingStmt, FallsThroughStmt newStmt) implement MutableStmtGraph.insertAfter(..)

2 participants

@wangzun66 @swissiety