Skip to content

add getParameterCount for methodSignature#1131

Merged
swissiety merged 7 commits intosoot-oss:developfrom
Liyw979:feat/parameter_count
Jan 6, 2025
Merged

add getParameterCount for methodSignature#1131
swissiety merged 7 commits intosoot-oss:developfrom
Liyw979:feat/parameter_count

Conversation

@Liyw979
Copy link
Copy Markdown
Contributor

@Liyw979 Liyw979 commented Nov 16, 2024

like getParameterCount of sootmethod

@swissiety
Copy link
Copy Markdown
Collaborator

swissiety commented Nov 16, 2024

please make SootMethod use the new method as well

@Liyw979
Copy link
Copy Markdown
Contributor Author

Liyw979 commented Nov 16, 2024 •
edited
Loading

@swissiety Done
It makes me wonder why do we do
this.parameterTypes = ImmutableUtils.immutableListOf(methodSignature.getParameterTypes()); in SootMethod
Can we remove this to make the code simpler?

@swissiety
Copy link
Copy Markdown
Collaborator

swissiety commented Jan 6, 2025

@swissiety Done It makes me wonder why do we do this.parameterTypes = ImmutableUtils.immutableListOf(methodSignature.getParameterTypes()); in SootMethod Can we remove this to make the code simpler?

yes, this makes sense!

@Liyw979
Copy link
Copy Markdown
Contributor Author

Liyw979 commented Jan 6, 2025 •
edited
Loading

SootMethod and MethodSignature now offer consistent APIs

@swissiety swissiety merged commit 88906ad into soot-oss:develop Jan 6, 2025
@Liyw979 Liyw979 deleted the feat/parameter_count branch January 23, 2025 15:07
@Liyw979 Liyw979 restored the feat/parameter_count branch January 23, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissiety swissiety swissiety approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Liyw979 @swissiety @stschott