Skip to content

Fix switch comparison#1126

Merged
stschott merged 7 commits intodevelopfrom
fix/switchComparison
Nov 5, 2024
Merged

Fix switch comparison#1126
stschott merged 7 commits intodevelopfrom
fix/switchComparison

Conversation

@stschott
Copy link
Copy Markdown
Collaborator

@stschott stschott commented Nov 5, 2024

No description provided.

Copy link
Copy Markdown
Collaborator

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swissiety
Copy link
Copy Markdown
Collaborator

hmm... MutableBlockStmtGraphTest.testRemoveMultipleTrapsWithDifferentExceptionTypes:1098 » IllegalArgument Invalid StmtGraph. A Trap is not created as a traps endStmt was not visited during the iteration of all Stmts.

@stschott
Copy link
Copy Markdown
Collaborator Author

stschott commented Nov 5, 2024

Flaky test? Locally the test case passes.

@stschott
Copy link
Copy Markdown
Collaborator Author

stschott commented Nov 5, 2024

The only method I changed is not even called when running the MutableBlockStmtGraphTest.testRemoveMultipleTrapsWithDifferentExceptionTypes test.

@stschott stschott merged commit 1cde415 into develop Nov 5, 2024
@stschott stschott deleted the fix/switchComparison branch November 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants