Merged
Conversation
…ead-assignment-eliminator-1
Contributor
Collaborator
Author
|
|
This was referenced Sep 15, 2024
…ead-assignment-eliminator-1 # Conflicts: # sootup.apk.frontend/pom.xml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1070 +/- ##
==============================================
- Coverage 69.41% 39.68% -29.73%
+ Complexity 4473 4448 -25
==============================================
Files 376 659 +283
Lines 17078 29623 +12545
Branches 2967 4839 +1872
==============================================
- Hits 11854 11756 -98
- Misses 4303 16956 +12653
+ Partials 921 911 -10 ☔ View full report in Codecov by Sentry. |
swissiety
reviewed
Sep 19, 2024
Collaborator
swissiety
left a comment
swissiety
left a comment
There was a problem hiding this comment.
and more dep mgmt to remove
…ead-assignment-eliminator-1
swissiety
approved these changes
Sep 20, 2024
pom.xml
Outdated
| <groupId>org.mockito</groupId> | ||
| <artifactId>mockito-junit-jupiter</artifactId> | ||
| <version>5.12.0</version> | ||
| <version>4.0.0</version> |
Collaborator
There was a problem hiding this comment.
lets make use of dependency mgmt here as well
Collaborator
Author
There was a problem hiding this comment.
so should I add v4 in apk.parser and revert back to v5 here right? @swissiety
sahilagichani14
deleted the
1034-bug-fix-bodyinterceptor-dead-assignment-eliminator-1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.