Fixed resource leaks in qilin module#1029
Merged
swissiety merged 5 commits intosoot-oss:developfrom Aug 20, 2024
Merged
Conversation
swissiety
reviewed
Aug 17, 2024
Collaborator
swissiety
left a comment
swissiety
left a comment
There was a problem hiding this comment.
Thx for your contribution Bryce!
I've seen more resource leaks listed in your document (of some we were already aware especially in the AnalysisInputLocations but had no time to fix them, yet). We would be very pleased if you could contribute to fixing them as well :)
sootup.qilin/src/main/java/qilin/core/reflection/TamiflexModel.java
Outdated
Show resolved
Hide resolved
Bryce7832
force-pushed
the
bug/fix_resource_leaks_quilin
branch
from
1285e39 to
948f0e1
Compare
Contributor
Author
|
Corrected resource leaks using try with resource instead of try/finally block. Awaiting approval. |
Contributor
Author
Yes, I will create an issue to fix the other resource leaks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This document contains an analysis of the approach used to fix the resource leaks in the sootup.qilin module. Fixes #1026