refactored pom dependencies for #1012#1018
Merged
swissiety merged 17 commits intosoot-oss:developfrom Aug 16, 2024
victoraysev:refactor/central-dependency-management
Merged
refactored pom dependencies for #1012#1018swissiety merged 17 commits intosoot-oss:developfrom victoraysev:refactor/central-dependency-management
swissiety merged 17 commits intosoot-oss:developfrom
victoraysev:refactor/central-dependency-management
Conversation
Contributor
Author
|
Hi @swissiety, is there anything I can address or improve to help get this pull request accepted? |
Collaborator
|
Hi, |
added 13 commits
August 15, 2024 16:47
Contributor
Author
|
Hi @swissiety |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1018 +/- ##
=============================================
+ Coverage 70.24% 71.96% +1.71%
- Complexity 4199 4453 +254
=============================================
Files 316 367 +51
Lines 15748 16389 +641
Branches 2699 2745 +46
=============================================
+ Hits 11062 11794 +732
+ Misses 3812 3689 -123
- Partials 874 906 +32 ☔ View full report in Codecov by Sentry. |
swissiety
reviewed
Aug 16, 2024
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactored pom dependencies
<version>${project.version}</version>in every submodule pom<dependencyManagement>block to the central POM file and included the module dependencies with<version>${project.version}</version>within it.opened for the first task of #1012