Skip to content

Feature/add cpg tests#1009

Merged
michaelyoukeim merged 8 commits intodevelopfrom
feature/addCpgTests
Aug 13, 2024
Merged

Feature/add cpg tests#1009
michaelyoukeim merged 8 commits intodevelopfrom
feature/addCpgTests

Conversation

@michaelyoukeim
Copy link
Copy Markdown
Collaborator

@michaelyoukeim michaelyoukeim commented Aug 7, 2024 •
edited by swissiety
Loading

  • Fixed the failing tests in the CPG module
  • Added a documentation

closes #1002

@michaelyoukeim michaelyoukeim self-assigned this Aug 7, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 7, 2024

Documentation Preview.

@michaelyoukeim michaelyoukeim marked this pull request as ready for review August 7, 2024 14:09
@stschott
Copy link
Copy Markdown
Collaborator

stschott commented Aug 7, 2024

Closes #1002

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.18%. Comparing base (2336e6e) to head (269a2e7).
Report is 138 commits behind head on develop.

Additional details and impacted files 
@@              Coverage Diff               @@
##             develop    #1009       +/-   ##
==============================================
- Coverage      70.30%   43.18%   -27.13%     
- Complexity      4203     4453      +250     
==============================================
  Files            317      587      +270     
  Lines          15736    27313    +11577     
  Branches        2701     4466     +1765     
==============================================
+ Hits           11063    11794      +731     
- Misses          3806    14612    +10806     
- Partials         867      907       +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

swissiety
swissiety approved these changes Aug 12, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swissiety
Copy link
Copy Markdown
Collaborator

swissiety commented Aug 12, 2024

coverage went down a lot.. maybe exclude qilin from test reports at the moment - ill add a comment to the qilin+tests issue

swissiety
swissiety reviewed Aug 12, 2024
View reviewed changes
@michaelyoukeim
Copy link
Copy Markdown
Collaborator Author

michaelyoukeim commented Aug 13, 2024

@swissiety Thanks! I'll merge with this status.

@michaelyoukeim michaelyoukeim merged commit f8a6da8 into develop Aug 13, 2024
@michaelyoukeim michaelyoukeim deleted the feature/addCpgTests branch August 13, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissiety swissiety swissiety approved these changes

@stschott stschott stschott approved these changes

Assignees

@michaelyoukeim michaelyoukeim

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelyoukeim @stschott @swissiety