FIX the issue "config load_minigraph -y" command fails#822
Merged
lguohan merged 9 commits intosonic-net:masterfrom Mar 22, 2020
Merged
FIX the issue "config load_minigraph -y" command fails#822lguohan merged 9 commits intosonic-net:masterfrom
lguohan merged 9 commits intosonic-net:masterfrom
Conversation
Signed-off-by: shine.chen <[email protected]>
Signed-off-by: shine.chen <[email protected]>
Signed-off-by: shine.chen <[email protected]>
Signed-off-by: shine.chen <[email protected]>
Signed-off-by: shine.chen <[email protected]>
Signed-off-by: shine.chen <[email protected]>
Signed-off-by: shine.chen <[email protected]>
lguohan
approved these changes
Mar 22, 2020
lguohan
added a commit
that referenced
this pull request
Mar 22, 2020
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
the return value of _get_optional_services() must be iterable This bug is imported from PR sonic-net#453 Co-authored-by: shine.chen <[email protected]>
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
…nic-net#848) This reverts commit f1c79d5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
FIX the issue "config load_minigraph -y" command fails
- How I did it
make sure the return value of _get_optional_services() is iterable
This bug is imported from PR #453
- How to verify it
test on nephos platform
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)