[Techsupport]Handle SAI kv pair if present in sai common profile#3196
Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom Mar 13, 2024
Merged
[Techsupport]Handle SAI kv pair if present in sai common profile#3196qiluo-msft merged 4 commits intosonic-net:masterfrom
qiluo-msft merged 4 commits intosonic-net:masterfrom
Conversation
vivekrnv
approved these changes
Mar 7, 2024
ganglyu
approved these changes
Mar 13, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Mar 21, 2024
…ic-net#3196) ### What I did Handle the SAI key value pair if it is present in sai common profile rather than specific profile for mellanox platforms. The concept of common sai profile is introduced in sonic-net/sonic-buildimage#18074 . After this the techsupport started to fail because of the absence of SAI_DUMP_STORE_PATH #### How I did it Check if the variable is not present in platform specific file and then read the common file. If the common file is not accessible due to syncd being down, fallback to default path which is hardcoded. #### How to verify it Running techsupport and ensuring it exits with code 0
Collaborator
|
Cherry-pick PR to 202311: #3227 |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 21, 2024
### What I did Handle the SAI key value pair if it is present in sai common profile rather than specific profile for mellanox platforms. The concept of common sai profile is introduced in sonic-net/sonic-buildimage#18074 . After this the techsupport started to fail because of the absence of SAI_DUMP_STORE_PATH #### How I did it Check if the variable is not present in platform specific file and then read the common file. If the common file is not accessible due to syncd being down, fallback to default path which is hardcoded. #### How to verify it Running techsupport and ensuring it exits with code 0
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Contributor
|
Need to cherry-pick it for 202305 Motivation is to cover theoretical case when SAI_DUMP_STORE_PATH cannot be found in sai.profile |
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
…ic-net#3196) ### What I did Handle the SAI key value pair if it is present in sai common profile rather than specific profile for mellanox platforms. The concept of common sai profile is introduced in sonic-net/sonic-buildimage#18074 . After this the techsupport started to fail because of the absence of SAI_DUMP_STORE_PATH #### How I did it Check if the variable is not present in platform specific file and then read the common file. If the common file is not accessible due to syncd being down, fallback to default path which is hardcoded. #### How to verify it Running techsupport and ensuring it exits with code 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Handle the SAI key value pair if it is present in sai common profile rather than specific profile for mellanox platforms. The concept of common sai profile is introduced in sonic-net/sonic-buildimage#18074 . After this the techsupport started to fail because of the absence of SAI_DUMP_STORE_PATH
How I did it
Check if the variable is not present in platform specific file and then read the common file. If the common file is not accessible due to syncd being down, fallback to default path which is hardcoded.
How to verify it
Running techsupport and ensuring it exits with code 0
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)