Skip to content

[sonic_installer]: Improve exception handling: introduce notes.#3029

Merged
saiarcot895 merged 1 commit intosonic-net:masterfrom
nazariig:master-cli-exc
Nov 20, 2023
Merged

[sonic_installer]: Improve exception handling: introduce notes.#3029
saiarcot895 merged 1 commit intosonic-net:masterfrom
nazariig:master-cli-exc

Conversation

@nazariig
Copy link
Copy Markdown
Collaborator

@nazariig nazariig commented Oct 30, 2023 •
edited
Loading

Signed-off-by: Nazarii Hnydyn [email protected]

What I did

  • Extended exception class with user notes

How I did it

  • Implemented new API

How to verify it

  • Run UTs

Tested branch (Please provide the tested image version)

  • master

Previous command output (if the output of a command-line utility has changed)

Traceback (most recent call last):
  File "/usr/local/bin/sonic_installer", line 8, in <module>
    sys.exit(sonic_installer())
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/sonic_installer/main.py", line 604, in install
    migrate_sonic_packages(bootloader, binary_image_version)
  File "/usr/local/lib/python3.9/dist-packages/sonic_installer/main.py", line 384, in migrate_sonic_packages
    run_command_or_raise(["chroot", new_image_mount, SONIC_PACKAGE_MANAGER, "migrate",
  File "/usr/local/lib/python3.9/dist-packages/sonic_installer/common.py", line 56, in run_command_or_raise
    raise sre
sonic_installer.exception.SonicRuntimeException: Failed to run command '['chroot', '/tmp/image-202305_RC.6-8c7a14378_Internal-fs', 'sonic-package-manager', 'migrate', '/tmp/packages.json', '--dockerd-socket', '/tmp/docker.sock', '-y']'

New command output (if the output of a command-line utility has changed)

Traceback (most recent call last):
  File "/usr/local/bin/sonic_installer", line 8, in <module>
    sys.exit(sonic_installer())
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/sonic_installer/main.py", line 604, in install
    migrate_sonic_packages(bootloader, binary_image_version)
  File "/usr/local/lib/python3.9/dist-packages/sonic_installer/main.py", line 384, in migrate_sonic_packages
    run_command_or_raise(["chroot", new_image_mount, SONIC_PACKAGE_MANAGER, "migrate",
  File "/usr/local/lib/python3.9/dist-packages/sonic_installer/common.py", line 56, in run_command_or_raise
    raise sre
sonic_installer.exception.SonicRuntimeException: Failed to run command '['chroot', '/tmp/image-202305_RC.6-8c7a14378_Internal-fs', 'sonic-package-manager', 'migrate', '/tmp/packages.json', '--dockerd-socket', '/tmp/docker.sock', '-y']'

STDOUT:
Failed to migrate packages 500 Server Error for http+docker://localhost/v1.41/images/urm.nvidia.com/sw-nbu-sws-sonic-docker/doai:1.1.0-202305-6/get: Internal Server Error ("open /var/lib/docker/overlay2/abaca4cf4dead46a809f8a10d8488099cb6df653617b0017fc5913228d077436/merged/usr/lib/python3/dist-packages/_distutils_hack/__pycache__/__init__.cpython-39.pyc: no such file or directory")

@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Oct 30, 2023

@stepanblyschak FYI

@nazariig nazariig mentioned this pull request Oct 30, 2023
Merged
1 task
@nazariig nazariig requested a review from dgsudharsan October 30, 2023 20:38
@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Nov 13, 2023

@prsunny / @qiluo-msft would you please help to review & merge?

@liat-grozovik liat-grozovik requested review from saiarcot895 and removed request for qiluo-msft and volodymyrsamotiy November 14, 2023 17:21
StormLiangMS pushed a commit that referenced this pull request Nov 15, 2023
@nazariig
[sonic_installer]: Improve exception handling: introduce notes. (#3028)
354dfe8 
What I did
Extended exception class with user notes
How I did it
Implemented new API
How to verify it
Run UTs
Tested branch (Please provide the tested image version)
 202305
Details if related
Backport from master: [sonic_installer]: Improve exception handling: introduce notes. #3029
@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Nov 15, 2023

@prsunny / @qiluo-msft just a kind reminder

@saiarcot895 saiarcot895 merged commit 8ebc56a into sonic-net:master Nov 20, 2023
nmoray pushed a commit to nmoray/sonic-utilities that referenced this pull request Jun 25, 2025
@nazariig @nmoray
[sonic_installer]: Improve exception handling: introduce notes. (soni…
a8df77d 
…c-net#3029)

Signed-off-by: Nazarii Hnydyn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saiarcot895 saiarcot895 saiarcot895 approved these changes

@dgsudharsan dgsudharsan dgsudharsan approved these changes

@stepanblyschak stepanblyschak stepanblyschak approved these changes

@liat-grozovik liat-grozovik liat-grozovik approved these changes

Assignees

No one assigned

Labels

Cherry Pick Conflict_202305 Enhancement Included in 202305 Branch Request for 202305 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nazariig @saiarcot895 @dgsudharsan @stepanblyschak @liat-grozovik @StormLiangMS