Skip to content

[202305][sonic_installer]: Improve exception handling: introduce notes#3028

Merged
StormLiangMS merged 1 commit intosonic-net:202305from
nazariig:202305-cli-exc
Nov 15, 2023
Merged

[202305][sonic_installer]: Improve exception handling: introduce notes#3028
StormLiangMS merged 1 commit intosonic-net:202305from
nazariig:202305-cli-exc

Conversation

@nazariig
Copy link
Copy Markdown
Collaborator

@nazariig nazariig commented Oct 30, 2023 •
edited
Loading

Signed-off-by: Nazarii Hnydyn [email protected]

What I did

  • Extended exception class with user notes

How I did it

  • Implemented new API

How to verify it

  • Run UTs

Tested branch (Please provide the tested image version)

  • 202305

Details if related

Previous command output (if the output of a command-line utility has changed)

Traceback (most recent call last):
  File "/usr/local/bin/sonic_installer", line 8, in <module>
    sys.exit(sonic_installer())
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/sonic_installer/main.py", line 604, in install
    migrate_sonic_packages(bootloader, binary_image_version)
  File "/usr/local/lib/python3.9/dist-packages/sonic_installer/main.py", line 384, in migrate_sonic_packages
    run_command_or_raise(["chroot", new_image_mount, SONIC_PACKAGE_MANAGER, "migrate",
  File "/usr/local/lib/python3.9/dist-packages/sonic_installer/common.py", line 56, in run_command_or_raise
    raise sre
sonic_installer.exception.SonicRuntimeException: Failed to run command '['chroot', '/tmp/image-202305_RC.6-8c7a14378_Internal-fs', 'sonic-package-manager', 'migrate', '/tmp/packages.json', '--dockerd-socket', '/tmp/docker.sock', '-y']'

New command output (if the output of a command-line utility has changed)

Traceback (most recent call last):
  File "/usr/local/bin/sonic_installer", line 8, in <module>
    sys.exit(sonic_installer())
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/sonic_installer/main.py", line 604, in install
    migrate_sonic_packages(bootloader, binary_image_version)
  File "/usr/local/lib/python3.9/dist-packages/sonic_installer/main.py", line 384, in migrate_sonic_packages
    run_command_or_raise(["chroot", new_image_mount, SONIC_PACKAGE_MANAGER, "migrate",
  File "/usr/local/lib/python3.9/dist-packages/sonic_installer/common.py", line 56, in run_command_or_raise
    raise sre
sonic_installer.exception.SonicRuntimeException: Failed to run command '['chroot', '/tmp/image-202305_RC.6-8c7a14378_Internal-fs', 'sonic-package-manager', 'migrate', '/tmp/packages.json', '--dockerd-socket', '/tmp/docker.sock', '-y']'

STDOUT:
Failed to migrate packages 500 Server Error for http+docker://localhost/v1.41/images/urm.nvidia.com/sw-nbu-sws-sonic-docker/doai:1.1.0-202305-6/get: Internal Server Error ("open /var/lib/docker/overlay2/abaca4cf4dead46a809f8a10d8488099cb6df653617b0017fc5913228d077436/merged/usr/lib/python3/dist-packages/_distutils_hack/__pycache__/__init__.cpython-39.pyc: no such file or directory")

@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Oct 30, 2023

@stepanblyschak FYI

@dgsudharsan
Copy link
Copy Markdown
Collaborator

dgsudharsan commented Oct 30, 2023

@nazariig Can you please ensure coverage? In addition can we create a PR on master?

@nazariig nazariig force-pushed the 202305-cli-exc branch 2 times, most recently from 47694c4 to 2115daa Compare November 1, 2023 11:55
@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Nov 1, 2023

@nazariig Can you please ensure coverage? In addition can we create a PR on master?

@dgsudharsan done

@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Nov 5, 2023

@StormLiangMS would you please help to review & merge?

@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Nov 8, 2023

@StormLiangMS just a kind reminder

1 similar comment
@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Nov 13, 2023

@StormLiangMS just a kind reminder

@liat-grozovik liat-grozovik requested review from saiarcot895 and removed request for StormLiangMS and volodymyrsamotiy November 14, 2023 17:23
@StormLiangMS StormLiangMS merged commit 354dfe8 into sonic-net:202305 Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgsudharsan dgsudharsan dgsudharsan approved these changes

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@saiarcot895 saiarcot895 Awaiting requested review from saiarcot895

Assignees

No one assigned

Labels

Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nazariig @dgsudharsan @liat-grozovik @StormLiangMS