[sflow][db_migrator] Egress Sflow support#3020
Merged
prsunny merged 3 commits intosonic-net:masterfrom Nov 28, 2023
Merged
Conversation
Signed-off-by: rajkumar38 <[email protected]>
Contributor
Author
|
@prsunny @vaibhavhd @qiluo-msft |
zhangyanzhao
requested review from
madhupalu,
qiluo-msft and
vadymhlushko-mlnx
Collaborator
|
@qiluo-msft @madhupalu @vadymhlushko-mlnx can you please help to review this PR? Thanks. |
prsunny
reviewed
Nov 17, 2023
scripts/db_migrator.py
Outdated
| log.log_info('Handling version_4_0_4') | ||
|
|
||
| sflow_tbl = self.configDB.get_table('SFLOW') | ||
| for k, v in sflow_tbl.items(): |
Contributor
There was a problem hiding this comment.
Please move this to migrate_sflow function.
Contributor
Author
There was a problem hiding this comment.
Fixed. Pls review
Signed-off-by: rajkumar38 <[email protected]>
Signed-off-by: rajkumar38 <[email protected]>
prsunny
approved these changes
Nov 28, 2023
yxieca
pushed a commit
that referenced
this pull request
Dec 14, 2023
* [sflow][db_migrator] Egress Sflow support
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
* [sflow][db_migrator] Egress Sflow support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Based on review comments from PR #2790, raised a separate PR for db_migrator changes as part of egress sFlow feature.
How I did it
How to verify it
Recompile sonic-utilities bdist_wheel and verify pytest
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)