Support reading/writing module EEPROM data by page and offset#3008
Merged
prgeor merged 19 commits intosonic-net:masterfrom Dec 8, 2023
Merged
Support reading/writing module EEPROM data by page and offset#3008prgeor merged 19 commits intosonic-net:masterfrom
prgeor merged 19 commits intosonic-net:masterfrom
Conversation
mihirpat1
reviewed
Oct 19, 2023
mihirpat1
previously approved these changes
Oct 20, 2023
keboliu
approved these changes
Oct 23, 2023
Collaborator
|
@mihirpat1 @prgeor would you please help to review again? |
mihirpat1
reviewed
Nov 28, 2023
Collaborator
Author
|
@mihirpat1 , I fixed the comments, could you please review again? |
mihirpat1
reviewed
Nov 29, 2023
mihirpat1
reviewed
Nov 29, 2023
mihirpat1
previously approved these changes
Nov 30, 2023
prgeor
reviewed
Dec 5, 2023
prgeor
reviewed
Dec 5, 2023
Collaborator
|
@Junchao-Mellanox is the dependency is still valid? I see the PR is closed. |
Collaborator
Author
Thanks for reminder. This dependency is no longer needed. |
prgeor
approved these changes
Dec 8, 2023
Contributor
|
@liat-grozovik @Junchao-Mellanox there is cherry pick conflict so need separate pr for 202311 |
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-utilities
that referenced
this pull request
Dec 8, 2023
…net#3008) * Support reading/writing module EEPROM data by page and offset * Fix unit test issue * Fix unit test issue * Fix review comment * Update command ref * Fix format * Update main.py * Fix review comments * Fix review comment * Remove un-intended change * Update Command-Reference.md * Update Command-Reference.md * Fix review comments * Fix review comments * User click.IntRange to avoid duplicate validation * Fix review comments * Update sfputil_test.py
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-utilities
that referenced
this pull request
Dec 8, 2023
…net#3008) * Support reading/writing module EEPROM data by page and offset * Fix unit test issue * Fix unit test issue * Fix review comment * Update command ref * Fix format * Update main.py * Fix review comments * Fix review comment * Remove un-intended change * Update Command-Reference.md * Update Command-Reference.md * Fix review comments * Fix review comments * User click.IntRange to avoid duplicate validation * Fix review comments * Update sfputil_test.py
Collaborator
Author
|
PR for 202311: #3073 |
liushilongbuaa
added
Request for 202311 Branch
and removed
Request for 202311 Branch
labels
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-utilities
that referenced
this pull request
Dec 14, 2023
…net#3008) * Support reading/writing module EEPROM data by page and offset * Fix unit test issue * Fix unit test issue * Fix review comment * Update command ref * Fix format * Update main.py * Fix review comments * Fix review comment * Remove un-intended change * Update Command-Reference.md * Update Command-Reference.md * Fix review comments * Fix review comments * User click.IntRange to avoid duplicate validation * Fix review comments * Update sfputil_test.py
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
…net#3008) * Support reading/writing module EEPROM data by page and offset * Fix unit test issue * Fix unit test issue * Fix review comment * Update command ref * Fix format * Update main.py * Fix review comments * Fix review comment * Remove un-intended change * Update Command-Reference.md * Update Command-Reference.md * Fix review comments * Fix review comments * User click.IntRange to avoid duplicate validation * Fix review comments * Update sfputil_test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add two CLIs:
Allow user to read/write EEPROM by page and offset
How I did it
See design:
sonic-net/SONiC#1475
How to verify it
Unit test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)