UT change: for db_migrator test do not check for RESTAPI cert values#2919
Merged
xumia merged 2 commits intosonic-net:masterfrom Jul 20, 2023
Merged
UT change: for db_migrator test do not check for RESTAPI cert values#2919xumia merged 2 commits intosonic-net:masterfrom
xumia merged 2 commits intosonic-net:masterfrom
Conversation
xumia
approved these changes
Jul 20, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Jul 25, 2023
…2919) What I did MSFT ADO: 24598790 Why: RESTAPI table has certs generated from minigraph parser. The values in RESTAPI table (cert and key names) are dependent on how they are hardcoded in minigraph parser. Current solution works on public repo, but breaks the internal build (different naming). What: Do not match values for RESTAPI attributes. The test still ensures that missing table and keys are migrated. How I did it How to verify it
rajkumar38
pushed a commit
to rajkumar38/sonic-utilities
that referenced
this pull request
Jul 25, 2023
…onic-net#2919) What I did MSFT ADO: 24598790 Why: RESTAPI table has certs generated from minigraph parser. The values in RESTAPI table (cert and key names) are dependent on how they are hardcoded in minigraph parser. Current solution works on public repo, but breaks the internal build (different naming). What: Do not match values for RESTAPI attributes. The test still ensures that missing table and keys are migrated. How I did it How to verify it
yxieca
pushed a commit
that referenced
this pull request
Aug 10, 2023
…2919) What I did MSFT ADO: 24598790 Why: RESTAPI table has certs generated from minigraph parser. The values in RESTAPI table (cert and key names) are dependent on how they are hardcoded in minigraph parser. Current solution works on public repo, but breaks the internal build (different naming). What: Do not match values for RESTAPI attributes. The test still ensures that missing table and keys are migrated. How I did it How to verify it
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 17, 2023
…2919) What I did MSFT ADO: 24598790 Why: RESTAPI table has certs generated from minigraph parser. The values in RESTAPI table (cert and key names) are dependent on how they are hardcoded in minigraph parser. Current solution works on public repo, but breaks the internal build (different naming). What: Do not match values for RESTAPI attributes. The test still ensures that missing table and keys are migrated. How I did it How to verify it
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
…onic-net#2919) What I did MSFT ADO: 24598790 Why: RESTAPI table has certs generated from minigraph parser. The values in RESTAPI table (cert and key names) are dependent on how they are hardcoded in minigraph parser. Current solution works on public repo, but breaks the internal build (different naming). What: Do not match values for RESTAPI attributes. The test still ensures that missing table and keys are migrated. How I did it How to verify it
StormLiangMS
pushed a commit
that referenced
this pull request
Sep 5, 2023
…2919) What I did MSFT ADO: 24598790 Why: RESTAPI table has certs generated from minigraph parser. The values in RESTAPI table (cert and key names) are dependent on how they are hardcoded in minigraph parser. Current solution works on public repo, but breaks the internal build (different naming). What: Do not match values for RESTAPI attributes. The test still ensures that missing table and keys are migrated. How I did it How to verify it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
MSFT ADO: 24598790
Why:
RESTAPI table has certs generated from minigraph parser.
The values in RESTAPI table (cert and key names) are dependent on how they are hardcoded in minigraph parser.
Current solution works on public repo, but breaks the internal build (different naming).
What:
Do not match values for RESTAPI attributes. The test still ensures that missing table and keys are migrated.
How I did it
How to verify it
UT passes now even when cert names are changed in expected JSON.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)