Flush RESTAPI db in fast-reboot shutdown path#2917
Merged
bingwang-ms merged 2 commits intosonic-net:masterfrom Jul 19, 2023
Merged
Flush RESTAPI db in fast-reboot shutdown path#2917bingwang-ms merged 2 commits intosonic-net:masterfrom
bingwang-ms merged 2 commits intosonic-net:masterfrom
Conversation
vaibhavhd
reviewed
Jul 19, 2023
| sonic-db-cli ASIC_DB FLUSHDB > /dev/null | ||
| sonic-db-cli COUNTERS_DB FLUSHDB > /dev/null | ||
| sonic-db-cli FLEX_COUNTER_DB FLUSHDB > /dev/null | ||
| sonic-db-cli RESTAPI_DB FLUSHDB > /dev/null |
Contributor
There was a problem hiding this comment.
This will get cleared for NVIDIA's warmboot (fastfast-reboot). I think that is not expected.
Should this check be restricted to fast-reboot? @prsunny ?
Contributor
Author
There was a problem hiding this comment.
I updated the code. Now it's limited to fast-reboot only.
prsunny
approved these changes
Jul 19, 2023
vaibhavhd
approved these changes
Jul 19, 2023
Contributor
Author
|
/azp run |
|
No commit pushedDate could be found for PR 2917 in repo sonic-net/sonic-utilities |
|
/easycla |
1 similar comment
Contributor
Author
|
/easycla |
Contributor
Author
Contributor
Author
|
PR filed for 202205 branch #2921 |
rajkumar38
pushed a commit
to rajkumar38/sonic-utilities
that referenced
this pull request
Jul 25, 2023
* Flush RESTAPI db in fast-reboot shutdown path
StormLiangMS
pushed a commit
that referenced
this pull request
Aug 6, 2023
* Flush RESTAPI db in fast-reboot shutdown path
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
* Flush RESTAPI db in fast-reboot shutdown path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
The PR is to flush
RESTAPI_DBin the fast-reboot shutdown path.After PR #2365, the table is not cleared because the
WARM_RESTART_ENABLE_TABLE|systemis set totrue.So below code in
swss.shdoesn't do the db flush.https://github.com/sonic-net/sonic-buildimage/blob/bdef73ea963064cdc9fbebb63ac381440c0fafd6/files/scripts/swss.sh#L168C1-L181C7
How I did it
Flush
RESTAPI_DBin the fast-reboot shutdown path.How to verify it
We have a sonic-mgmt test case
restapi/test_restapi.py::test_check_reset_statusto cover the feature.The test can pass after this change.
Previous command output (if the output of a command-line utility has changed)
N/A
New command output (if the output of a command-line utility has changed)
N/A