Skip to content

[CRM][DASH] Extend CRM utility to support DASH resources.#2800

Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom
oleksandrivantsiv:crm-dash
May 31, 2023
Merged

[CRM][DASH] Extend CRM utility to support DASH resources.#2800
liat-grozovik merged 1 commit intosonic-net:masterfrom
oleksandrivantsiv:crm-dash

Conversation

@oleksandrivantsiv
Copy link
Copy Markdown
Collaborator

@oleksandrivantsiv oleksandrivantsiv commented Apr 18, 2023 •
edited
Loading

What I did

Extend CRM utility to support DASH resources.

How I did it

Add "dash" sub-group to "crm config" and "crm show" commands.
"dash" sub-group will be available for the user only if SONiC runs on the DPU.

How to verify it

Compile sonic-utilities package. The tests will run automatically.
To cover dash-related functionality new test tests/crm_dash_test.py was added.
Code coverage is the following:
crm/dash_config.py - 99%
crm/dash_show.py - 98%
crm/main.py - 92%

Previous command output (if the output of a command-line utility has changed)

The existing commands are not affected.

New command output (if the output of a command-line utility has changed)

crm config

  • thresholds dash [vnet|eni|eni-ether-address] type [percentage|used|count]
  • thresholds dash [vnet|eni|eni-ether-address] [low|high]
  • thresholds dash [ipv4|ipv6] [inbound|outbound] routing type [percentage|used|count]
  • thresholds dash [ipv4|ipv6] [inbound|outbound] routing [low|high]
  • thresholds dash [ipv4|ipv6] pa-validation [percentage|used|count]
  • thresholds dash [ipv4|ipv6] pa-validation [low|high]
  • thresholds dash [ipv4|ipv6] outbound ca-to-pa [percentage|used|count]
  • thresholds dash [ipv4|ipv6] outbound ca-to-pa [low|high]
  • thresholds dash [ipv4|ipv6] acl group [percentage|used|count]
  • thresholds dash [ipv4|ipv6] acl group [low|high]
  • thresholds dash [ipv4|ipv6] acl rule [percentage|used|count]
  • thresholds dash [ipv4|ipv6] acl rule [low|high]

crm show

  • [resources|thresholds] dash [vnet|eni|eni-ether-address]
  • [resources|thresholds] dash [ipv4|ipv6] [inbound|outbound] routing
  • [resources|thresholds] dash [ipv4|ipv6] pa-validation
  • [resources|thresholds] dash [ipv4|ipv6] outbound ca-to-pa
  • [resources|thresholds] dash [ipv4|ipv6] acl group
  • [resources|thresholds] dash [ipv4|ipv6] acl rule

show thresholds all

Resource Name                Threshold Type      Low Threshold    High Threshold
---------------------------  ----------------  ---------------  ----------------
dash_vnet                    percentage                     70                85
dash_eni                     percentage                     70                85
dash_eni_ether_address_map   percentage                     70                85
dash_ipv4_inbound_routing    percentage                     70                85
dash_ipv6_inbound_routing    percentage                     70                85
dash_ipv4_outbound_routing   percentage                     70                85
dash_ipv6_outbound_routing   percentage                     70                85
dash_ipv4_pa_validation      percentage                     70                85
dash_ipv6_pa_validation      percentage                     70                85
dash_ipv4_outbound_ca_to_pa  percentage                     70                85
dash_ipv6_outbound_ca_to_pa  percentage                     70                85
dash_ipv4_acl_group          percentage                     70                85
dash_ipv6_acl_group          percentage                     70                85
dash_ipv4_acl_rule           percentage                     70                85
dash_ipv6_acl_rule           percentage                     70                85

show resources all

Resource Name                  Used Count    Available Count
---------------------------  ------------  -----------------
dash_vnet                               2          200000000
dash_eni                                9            1000000
dash_eni_ether_address_map              9            1000000
dash_ipv4_inbound_routing               9          200000000
dash_ipv6_inbound_routing               0          200000000
dash_ipv4_outbound_routing              9            1000000
dash_ipv6_outbound_routing              0            1000000
dash_ipv4_pa_validation                 0            1000000
dash_ipv6_pa_validation                 0            1000000
dash_ipv4_outbound_ca_to_pa             0            1000000
dash_ipv6_outbound_ca_to_pa             0            1000000
dash_ipv4_acl_group                    27          200000000
dash_ipv6_acl_group                     0          200000000

@oleksandrivantsiv oleksandrivantsiv marked this pull request as draft April 18, 2023 11:29
@oleksandrivantsiv oleksandrivantsiv marked this pull request as ready for review April 25, 2023 14:01
@oleksandrivantsiv oleksandrivantsiv requested a review from prsunny May 26, 2023 08:49
@oleksandrivantsiv oleksandrivantsiv self-assigned this May 26, 2023
@oleksandrivantsiv
Copy link
Copy Markdown
Collaborator Author

oleksandrivantsiv commented May 26, 2023

@prsunny kindly reminder to review PR.

@prsunny prsunny added the dash label May 27, 2023
@prsunny
Copy link
Copy Markdown
Contributor

prsunny commented May 30, 2023

@oleksandrivantsiv , can you please update description with old and new command? Any change to existing command on non-dash platforms by introducing this?

@oleksandrivantsiv
Copy link
Copy Markdown
Collaborator Author

oleksandrivantsiv commented May 30, 2023

@oleksandrivantsiv , can you please update description with old and new command? Any change to existing command on non-dash platforms by introducing this?

@prsunny description is updated. The existing commands are not affected.

prsunny
prsunny approved these changes May 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liat-grozovik liat-grozovik merged commit 6e0ee3e into sonic-net:master May 31, 2023
@maipbui maipbui mentioned this pull request Jun 4, 2023
Merged
10 tasks
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Jun 5, 2023
@dprital
[submodule] Advance sonic-utilities pointer
19930c4 
Update sonic-utilities submodule pointer to include the following:
* 5c9b217 Fix issue: out of range sflow polling interval is accepted and stored in config_db ([sonic-net#2847](sonic-net/sonic-utilities#2847))
* 72ca484 Add CLI configuration options for teamd retry count feature ([sonic-net#2642](sonic-net/sonic-utilities#2642))
* 359dfc0 [Clock] Implement clock CLI ([sonic-net#2793](sonic-net/sonic-utilities#2793))
* b316fc2 Add transceiver status CLI to show output from TRANSCEIVER_STATUS table ([sonic-net#2772](sonic-net/sonic-utilities#2772))
* dc59dbd Replace pickle by json ([sonic-net#2849](sonic-net/sonic-utilities#2849))
* a66f41c [show] replace shell=True, replace xml by lxml, replace exit by sys.exit ([sonic-net#2666](sonic-net/sonic-utilities#2666))
* 5750057 [utilities_common] replace shell=True ([sonic-net#2718](sonic-net/sonic-utilities#2718))
* 6e0ee3e [CRM][DASH] Extend CRM utility to support DASH resources. ([sonic-net#2800](sonic-net/sonic-utilities#2800))
* b2c29b0 [config] Generate sysinfo in single asic ([sonic-net#2856](sonic-net/sonic-utilities#2856))

Signed-off-by: dprital <[email protected]>
@dprital dprital mentioned this pull request Jun 5, 2023
Closed
10 tasks
StormLiangMS pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jun 5, 2023
@maipbui
modify commands using utilities_common.cli.run_command and advance so…
1477f77 
…nic-utilities submodule on master (#15193)

Dependency:
sonic-net/sonic-utilities#2718

Why I did it
This PR sonic-net/sonic-utilities#2718 reduce shell=True usage in utilities_common.cli.run_command() function.

Work item tracking
Microsoft ADO (number only): 15022050
How I did it
Replace strings commands using utilities_common.cli.run_command() function to list of strings

due to circular dependency, advance sonic-utilities submodule
72ca484 (HEAD -> master, upstream/master, upstream/HEAD) Add CLI configuration options for teamd retry count feature (sonic-net/sonic-utilities#2642)
359dfc0 [Clock] Implement clock CLI (sonic-net/sonic-utilities#2793)
b316fc2 Add transceiver status CLI to show output from TRANSCEIVER_STATUS table (sonic-net/sonic-utilities#2772)
dc59dbd Replace pickle by json (sonic-net/sonic-utilities#2849)
a66f41c [show] replace shell=True, replace xml by lxml, replace exit by sys.exit (sonic-net/sonic-utilities#2666)
5750057 [utilities_common] replace shell=True (sonic-net/sonic-utilities#2718)
6e0ee3e [CRM][DASH] Extend CRM utility to support DASH resources. (sonic-net/sonic-utilities#2800)
b2c29b0 [config] Generate sysinfo in single asic (sonic-net/sonic-utilities#2856)
pdhruv-marvell pushed a commit to pdhruv-marvell/sonic-utilities that referenced this pull request Aug 23, 2023
@oleksandrivantsiv @pdhruv-marvell
[CRM][DASH] Extend CRM utility to support DASH resources. (sonic-net#…
bad9c21 
…2800)

- What I did
Extend CRM utility to support DASH resources.

- How I did it
Add "dash" sub-group to "crm config" and "crm show" commands.
"dash" sub-group will be available for the user only if SONiC runs on the DPU.

- How to verify it
Compile sonic-utilities package. The tests will run automatically.
To cover dash-related functionality new test tests/crm_dash_test.py was added.
Code coverage is the following:
crm/dash_config.py - 99%
crm/dash_show.py - 98%
crm/main.py - 92%

- Previous command output (if the output of a command-line utility has changed)
The existing commands are not affected.

- New command output (if the output of a command-line utility has changed)

crm config

thresholds dash [vnet|eni|eni-ether-address] type [percentage|used|count]
thresholds dash [vnet|eni|eni-ether-address] [low|high]
thresholds dash [ipv4|ipv6] [inbound|outbound] routing type [percentage|used|count]
thresholds dash [ipv4|ipv6] [inbound|outbound] routing [low|high]
thresholds dash [ipv4|ipv6] pa-validation [percentage|used|count]
thresholds dash [ipv4|ipv6] pa-validation [low|high]
thresholds dash [ipv4|ipv6] outbound ca-to-pa [percentage|used|count]
thresholds dash [ipv4|ipv6] outbound ca-to-pa [low|high]
thresholds dash [ipv4|ipv6] acl group [percentage|used|count]
thresholds dash [ipv4|ipv6] acl group [low|high]
thresholds dash [ipv4|ipv6] acl rule [percentage|used|count]
thresholds dash [ipv4|ipv6] acl rule [low|high]

crm show

[resources|thresholds] dash [vnet|eni|eni-ether-address]
[resources|thresholds] dash [ipv4|ipv6] [inbound|outbound] routing
[resources|thresholds] dash [ipv4|ipv6] pa-validation
[resources|thresholds] dash [ipv4|ipv6] outbound ca-to-pa
[resources|thresholds] dash [ipv4|ipv6] acl group
[resources|thresholds] dash [ipv4|ipv6] acl rule

show thresholds all

show resources all

Signed-off-by: Oleksandr Ivantsiv <[email protected]>
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
@maipbui @sonic-otn
modify commands using utilities_common.cli.run_command and advance so…
41da53d 
…nic-utilities submodule on master (sonic-net#15193)

Dependency:
sonic-net/sonic-utilities#2718

Why I did it
This PR sonic-net/sonic-utilities#2718 reduce shell=True usage in utilities_common.cli.run_command() function.

Work item tracking
Microsoft ADO (number only): 15022050
How I did it
Replace strings commands using utilities_common.cli.run_command() function to list of strings

due to circular dependency, advance sonic-utilities submodule
72ca484 (HEAD -> master, upstream/master, upstream/HEAD) Add CLI configuration options for teamd retry count feature (sonic-net/sonic-utilities#2642)
359dfc0 [Clock] Implement clock CLI (sonic-net/sonic-utilities#2793)
b316fc2 Add transceiver status CLI to show output from TRANSCEIVER_STATUS table (sonic-net/sonic-utilities#2772)
dc59dbd Replace pickle by json (sonic-net/sonic-utilities#2849)
a66f41c [show] replace shell=True, replace xml by lxml, replace exit by sys.exit (sonic-net/sonic-utilities#2666)
5750057 [utilities_common] replace shell=True (sonic-net/sonic-utilities#2718)
6e0ee3e [CRM][DASH] Extend CRM utility to support DASH resources. (sonic-net/sonic-utilities#2800)
b2c29b0 [config] Generate sysinfo in single asic (sonic-net/sonic-utilities#2856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgsudharsan dgsudharsan dgsudharsan approved these changes

@prsunny prsunny prsunny approved these changes

@Yakiv-Huryk Yakiv-Huryk Yakiv-Huryk approved these changes

Assignees

@oleksandrivantsiv oleksandrivantsiv

Labels

dash

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oleksandrivantsiv @prsunny @dgsudharsan @Yakiv-Huryk @liat-grozovik