[hash]: Implement GH frontend by nazariig · Pull Request #2580 · sonic-net/sonic-utilities

nazariig · 2023-01-04T12:35:12Z

Signed-off-by: Nazarii Hnydyn [email protected]

DEPENDS:

[hash]: Add GH DB schema sonic-swss-common#733

HLD: sonic-net/SONiC#1101

What I did

Implemented CLI for Generic Hash feature

How I did it

Integrated Generic Hash interface into config and show CLI root

How to verify it

Run Generic Hash CLI UTs

Previous command output (if the output of a command-line utility has changed)

N/A

New command output (if the output of a command-line utility has changed)

N/A

nazariig · 2023-02-14T16:30:54Z

@prsunny could you please have a look?

nazariig · 2023-02-23T15:03:44Z

@abdosi just a kind reminder

nazariig · 2023-02-28T19:51:28Z

@abdosi just a kind reminder

config/plugins/sonic-hash.py

abdosi · 2023-02-28T20:10:40Z

other than above 2 comments rest LGTM

dprital · 2023-05-24T10:46:10Z

@abdosi , @prsunny - now after the review, can you please approve this PR ?

nazariig · 2023-06-06T13:39:33Z

/azpw run

mssonicbld · 2023-06-06T13:39:35Z

/AzurePipelines run

azure-pipelines · 2023-06-06T13:39:45Z

Azure Pipelines successfully started running 1 pipeline(s).

nazariig · 2023-06-27T09:45:37Z

@abdosi just a kind reminder

nazariig · 2023-06-30T09:16:01Z

/azpw run

mssonicbld · 2023-06-30T09:16:03Z

/AzurePipelines run

azure-pipelines · 2023-06-30T09:16:13Z

Azure Pipelines successfully started running 1 pipeline(s).

nazariig · 2023-07-06T13:06:30Z

@abdosi just a kind reminder

nazariig · 2023-07-10T07:17:48Z

@abdosi thanks a lot for approving!

liat-grozovik

@nazariig as this introduce new feature CLI I would appreciate if you can add them to the command reference guide md file.

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig · 2023-07-10T10:01:50Z

@nazariig as this introduce new feature CLI I would appreciate if you can add them to the command reference guide md file.

@liat-grozovik done

Update sonic-utilities submodule pointer to include the following: * ff380e0 [hash]: Implement GH frontend ([sonic-net#2580](sonic-net/sonic-utilities#2580)) * 61bad06 [db_migrator] Set correct CURRENT_VERSION, extend UT ([sonic-net#2895](sonic-net/sonic-utilities#2895)) * 6b8ee47 [CLI][Show][BGP] Show BGP Change for no neighbor scenario ([sonic-net#2885](sonic-net/sonic-utilities#2885)) * 73d8d63 [doc] Update Command-Reference.md, change show bgp peer command to show bfd peer ([sonic-net#2750](sonic-net/sonic-utilities#2750)) * 7bc08c2 [db_migrator] Remove hardcoded config and migrate config from minigraph ([sonic-net#2887](sonic-net/sonic-utilities#2887)) * b1aa942 [generate_dump]: Enhance show techsupport for Marvell platform ([sonic-net#2676](sonic-net/sonic-utilities#2676)) * 316b14c Add support for secure upgrade ([sonic-net#2698](sonic-net/sonic-utilities#2698)) * dc2945b [dns] Implement config and show commands for static DNS. ([sonic-net#2737](sonic-net/sonic-utilities#2737)) * 8414a70 [chassis][multi asic] change acl_loader to use tcp socket for db communication ([sonic-net#2525](sonic-net/sonic-utilities#2525)) * 0b629ba Revert [chassis][voq] Clear fabric counters queue/port (2789) ([sonic-net#2882](sonic-net/sonic-utilities#2882)) * 3ba8241 [db_migtrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->master upgrade + fast-reboot. Add UT. ([sonic-net#2839](sonic-net/sonic-utilities#2839)) * fceef2e [chassis][voq] Clear fabric counters queue/port ([sonic-net#2789](sonic-net/sonic-utilities#2789)) Signed-off-by: dgsudharsan <[email protected]>

Update sonic-utilities submodule pointer to include the following: * ff380e0 [hash]: Implement GH frontend ([#2580](sonic-net/sonic-utilities#2580)) * 61bad06 [db_migrator] Set correct CURRENT_VERSION, extend UT ([#2895](sonic-net/sonic-utilities#2895)) * 6b8ee47 [CLI][Show][BGP] Show BGP Change for no neighbor scenario ([#2885](sonic-net/sonic-utilities#2885)) * 73d8d63 [doc] Update Command-Reference.md, change show bgp peer command to show bfd peer ([#2750](sonic-net/sonic-utilities#2750)) * 7bc08c2 [db_migrator] Remove hardcoded config and migrate config from minigraph ([#2887](sonic-net/sonic-utilities#2887)) * b1aa942 [generate_dump]: Enhance show techsupport for Marvell platform ([#2676](sonic-net/sonic-utilities#2676)) * 316b14c Add support for secure upgrade ([#2698](sonic-net/sonic-utilities#2698)) * dc2945b [dns] Implement config and show commands for static DNS. ([#2737](sonic-net/sonic-utilities#2737)) * 8414a70 [chassis][multi asic] change acl_loader to use tcp socket for db communication ([#2525](sonic-net/sonic-utilities#2525)) * 0b629ba Revert [chassis][voq] Clear fabric counters queue/port (2789) ([#2882](sonic-net/sonic-utilities#2882)) * 3ba8241 [db_migtrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->master upgrade + fast-reboot. Add UT. ([#2839](sonic-net/sonic-utilities#2839)) * fceef2e [chassis][voq] Clear fabric counters queue/port ([#2789](sonic-net/sonic-utilities#2789)) Signed-off-by: dgsudharsan <[email protected]>

StormLiangMS · 2023-08-14T07:42:19Z

new feature, no for cherry-pick

HLD sonic-net/SONiC#1101 - What I did Implemented CLI for Generic Hash feature - How I did it Integrated Generic Hash interface into config and show CLI root - How to verify it Run Generic Hash CLI UTs Signed-off-by: Nazarii Hnydyn <[email protected]>

Update sonic-utilities submodule pointer to include the following: * ff380e0 [hash]: Implement GH frontend ([sonic-net#2580](sonic-net/sonic-utilities#2580)) * 61bad06 [db_migrator] Set correct CURRENT_VERSION, extend UT ([sonic-net#2895](sonic-net/sonic-utilities#2895)) * 6b8ee47 [CLI][Show][BGP] Show BGP Change for no neighbor scenario ([sonic-net#2885](sonic-net/sonic-utilities#2885)) * 73d8d63 [doc] Update Command-Reference.md, change show bgp peer command to show bfd peer ([sonic-net#2750](sonic-net/sonic-utilities#2750)) * 7bc08c2 [db_migrator] Remove hardcoded config and migrate config from minigraph ([sonic-net#2887](sonic-net/sonic-utilities#2887)) * b1aa942 [generate_dump]: Enhance show techsupport for Marvell platform ([sonic-net#2676](sonic-net/sonic-utilities#2676)) * 316b14c Add support for secure upgrade ([sonic-net#2698](sonic-net/sonic-utilities#2698)) * dc2945b [dns] Implement config and show commands for static DNS. ([sonic-net#2737](sonic-net/sonic-utilities#2737)) * 8414a70 [chassis][multi asic] change acl_loader to use tcp socket for db communication ([sonic-net#2525](sonic-net/sonic-utilities#2525)) * 0b629ba Revert [chassis][voq] Clear fabric counters queue/port (2789) ([sonic-net#2882](sonic-net/sonic-utilities#2882)) * 3ba8241 [db_migtrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->master upgrade + fast-reboot. Add UT. ([sonic-net#2839](sonic-net/sonic-utilities#2839)) * fceef2e [chassis][voq] Clear fabric counters queue/port ([sonic-net#2789](sonic-net/sonic-utilities#2789)) Signed-off-by: dgsudharsan <[email protected]>

nazariig mentioned this pull request Jan 4, 2023

Generic Hash HLD sonic-net/SONiC#1101

Merged

nazariig force-pushed the master-hash-rel branch from fc00b68 to ea5f644 Compare January 5, 2023 10:47

nazariig requested review from liat-grozovik and volodymyrsamotiy January 5, 2023 17:04

nazariig force-pushed the master-hash-rel branch 2 times, most recently from 05f610e to d941232 Compare January 11, 2023 09:07

nazariig requested a review from prsunny February 8, 2023 20:51

prsunny requested a review from abdosi February 14, 2023 19:45

abdosi reviewed Feb 28, 2023

View reviewed changes

config/plugins/sonic-hash.py Show resolved Hide resolved

abdosi reviewed Feb 28, 2023

View reviewed changes

config/plugins/sonic-hash.py Show resolved Hide resolved

nazariig force-pushed the master-hash-rel branch from d941232 to 3732e16 Compare April 26, 2023 09:19

nazariig force-pushed the master-hash-rel branch from 3732e16 to 7295105 Compare May 6, 2023 12:38

nazariig force-pushed the master-hash-rel branch 3 times, most recently from 77c1229 to b62dadb Compare June 6, 2023 12:08

nazariig force-pushed the master-hash-rel branch from b62dadb to 79f444b Compare June 30, 2023 08:53

abdosi previously approved these changes Jul 7, 2023

View reviewed changes

nazariig added the Request for 202305 Branch label Jul 10, 2023

liat-grozovik requested changes Jul 10, 2023

View reviewed changes

nazariig added 2 commits July 10, 2023 12:22

[hash]: Implement GH frontend.

0a33344

Signed-off-by: Nazarii Hnydyn <[email protected]>

[hash]: Add GH UM reference.

08bf4b2

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig dismissed abdosi’s stale review via 08bf4b2 July 10, 2023 09:59

nazariig force-pushed the master-hash-rel branch from b3acfc1 to 08bf4b2 Compare July 10, 2023 09:59

liat-grozovik approved these changes Jul 10, 2023

View reviewed changes

liat-grozovik merged commit ff380e0 into sonic-net:master Jul 10, 2023

dgsudharsan mentioned this pull request Jul 11, 2023

[submodule] Advance sonic-utilities pointer sonic-net/sonic-buildimage#15779

Merged

11 tasks

dgsudharsan removed the Request for 202305 Branch label Oct 9, 2023

Conversation

nazariig commented Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

nazariig commented Feb 14, 2023

Uh oh!

nazariig commented Feb 23, 2023

Uh oh!

nazariig commented Feb 28, 2023

Uh oh!

Uh oh!

Uh oh!

abdosi commented Feb 28, 2023

Uh oh!

dprital commented May 24, 2023

Uh oh!

nazariig commented Jun 6, 2023

Uh oh!

mssonicbld commented Jun 6, 2023

Uh oh!

azure-pipelines bot commented Jun 6, 2023

Uh oh!

nazariig commented Jun 27, 2023

Uh oh!

nazariig commented Jun 30, 2023

Uh oh!

mssonicbld commented Jun 30, 2023

Uh oh!

azure-pipelines bot commented Jun 30, 2023

Uh oh!

nazariig commented Jul 6, 2023

Uh oh!

nazariig commented Jul 10, 2023

Uh oh!

liat-grozovik left a comment

Choose a reason for hiding this comment

Uh oh!

nazariig commented Jul 10, 2023

Uh oh!

StormLiangMS commented Aug 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nazariig commented Jan 4, 2023 •

edited

Loading