show linkmgrd status in show mux status#2254
Merged
zjswhhh merged 3 commits intosonic-net:masterfrom Jul 5, 2022
Merged
Conversation
yxieca
approved these changes
Jul 5, 2022
vdahiya12
approved these changes
Jul 5, 2022
Contributor
Author
|
Per offline discussion with @yxieca, will add a separate CLI for tunnel route, to show both soc ip, server ip tunnel routes. |
yxieca
pushed a commit
that referenced
this pull request
Jul 5, 2022
What I did Replace status in show mux status with APP DB MUX_CABLE_TABLE:<port_name>, which is written by linkmgrd and indicates linkmgrd's state transition. This change is required for active-active dualtor setup. In active-active setup, we care more about whether state transition happens on ToR side. In tests, we want to see if linkmgrd makes immediate reaction on link state changes. If we continue to use STATE DB entries, when gRPC is not available, we will get unknow in show mux status, which is not informatic and not the actual value we want to check. sign-off: Jing Zhang [email protected] How I did it Use APP DB entries instead of STATE DB. Move STATE DB to column SERVER_STATUS. How to verify it Unit tests with mock DB values. Tests on dual testbeds.
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Jul 7, 2022
Update sonic-utilities submodule pointer to include the following: * [show] add new CLI to show tunnel route objects ([sonic-net#2255](sonic-net/sonic-utilities#2255)) * Add support for IP interface loopback action ([sonic-net#2192](sonic-net/sonic-utilities#2192)) * Update load minigraph to load backend acl ([sonic-net#2236](sonic-net/sonic-utilities#2236)) * show linkmgrd status in ([sonic-net#2254](sonic-net/sonic-utilities#2254)) Signed-off-by: dprital <[email protected]>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Replace status in
show mux statuswith APP DBMUX_CABLE_TABLE:<port_name>, which is written by linkmgrd and indicates linkmgrd's state transition.This change is required for active-active dualtor setup. In active-active setup, we care more about whether state transition happens on ToR side. In tests, we want to see if linkmgrd makes immediate reaction on link state changes. If we continue to use STATE DB entries, when gRPC is not available, we will get
unknowinshow mux status, which is not informatic and not the actual value we want to check.sign-off: Jing Zhang [email protected]
How I did it
Use APP DB entries instead of STATE DB.
Move STATE DB to column
SERVER_STATUS.How to verify it
Unit tests with mock DB values.
Tests on dual testbeds.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)