[pfcwd] Fix the return code in invalid case#1691
Merged
neethajohn merged 2 commits intosonic-net:masterfrom Jun 25, 2021
Merged
[pfcwd] Fix the return code in invalid case#1691neethajohn merged 2 commits intosonic-net:masterfrom
neethajohn merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
yxieca
approved these changes
Jun 22, 2021
smaheshm
approved these changes
Jun 22, 2021
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@neethajohn This PR could not be cleanly cherry-pick to 202012. Please submit another PR. |
5 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Jun 30, 2021
Backport #1691 - What I did Set the correct return code when pfcwd command is specified with invalid options Signed-off-by: Neetha John <[email protected]>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-utilities
that referenced
this pull request
Aug 10, 2021
Signed-off-by: Neetha John <[email protected]> Fixes sonic-net#1690 What I did Set the correct return code when pfcwd command is specified with invalid options How to verify it Modified the unit test to check for the correct return code and ran them and they passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1690
What I did
Set the correct return code when pfcwd command is specified with invalid options
How to verify it
Modified the unit test to check for the correct return code and ran them and they passed