Skip to content

Updated natshow script to support DNAT Pool changes#1001

Merged
arlakshm merged 1 commit intosonic-net:masterfrom
AkhileshSamineni:dnat_pool_changes_master
Oct 8, 2020
Merged

Updated natshow script to support DNAT Pool changes#1001
arlakshm merged 1 commit intosonic-net:masterfrom
AkhileshSamineni:dnat_pool_changes_master

Conversation

@AkhileshSamineni
Copy link
Copy Markdown
Contributor

@AkhileshSamineni AkhileshSamineni commented Jul 21, 2020

Updated the natshow script to get the nat type from newly added attribute.

Depends on :
sonic-net/sonic-swss#1358
sonic-net/sonic-sairedis#644
sonic-net/sonic-swss-common#367

Signed-off-by: Akhilesh Samineni [email protected]

@jleveque
Copy link
Copy Markdown
Contributor

Retest this please

@AkhileshSamineni
Copy link
Copy Markdown
Contributor Author

Retest this please

@AkhileshSamineni
Copy link
Copy Markdown
Contributor Author

@rlhui @arlakshm Could you please review and merge this PR.

@AkhileshSamineni
Copy link
Copy Markdown
Contributor Author

@arlakshm @rlhui Could you please review and merge these changes.

Copy link
Copy Markdown
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arlakshm arlakshm merged commit efb08f8 into sonic-net:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants